* [PATCH 0/1] MAINTAINERS: Add Python library stanza
@ 2020-07-10 21:57 John Snow
2020-07-10 21:57 ` [PATCH 1/1] " John Snow
0 siblings, 1 reply; 9+ messages in thread
From: John Snow @ 2020-07-10 21:57 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, peter.maydell, alex.bennee, ehabkost, crosa
John Snow (1):
MAINTAINERS: Add Python library stanza
MAINTAINERS | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
--
2.21.3
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/1] MAINTAINERS: Add Python library stanza
2020-07-10 21:57 [PATCH 0/1] MAINTAINERS: Add Python library stanza John Snow
@ 2020-07-10 21:57 ` John Snow
2020-07-13 8:19 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: John Snow @ 2020-07-10 21:57 UTC (permalink / raw)
To: qemu-devel; +Cc: John Snow, peter.maydell, alex.bennee, ehabkost, crosa
I'm proposing that I split the actual Python library off from the other
miscellaneous python scripts we have and declare it maintained. Add
myself as a maintainer of this folder, along with Cleber.
Signed-off-by: John Snow <jsnow@redhat.com>
---
MAINTAINERS | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6aa54f7f8f..fe1dcd5a76 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2280,11 +2280,18 @@ S: Maintained
F: include/sysemu/cryptodev*.h
F: backends/cryptodev*.c
+Python library
+M: John Snow <jsnow@redhat.com>
+M: Cleber Rosa <crosa@redhat.com>
+R: Eduardo Habkost <ehabkost@redhat.com>
+S: Maintained
+F: python/*
+T: git https://gitlab.com/jsnow/qemu.git python
+
Python scripts
M: Eduardo Habkost <ehabkost@redhat.com>
M: Cleber Rosa <crosa@redhat.com>
S: Odd fixes
-F: python/qemu/*py
F: scripts/*.py
F: tests/*.py
--
2.21.3
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 1/1] MAINTAINERS: Add Python library stanza
2020-07-10 21:57 ` [PATCH 1/1] " John Snow
@ 2020-07-13 8:19 ` Philippe Mathieu-Daudé
2020-07-13 13:35 ` Alex Bennée
2020-07-20 21:06 ` Cleber Rosa
2 siblings, 0 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-07-13 8:19 UTC (permalink / raw)
To: John Snow, qemu-devel; +Cc: peter.maydell, alex.bennee, ehabkost, crosa
On 7/10/20 11:57 PM, John Snow wrote:
> I'm proposing that I split the actual Python library off from the other
> miscellaneous python scripts we have and declare it maintained. Add
> myself as a maintainer of this folder, along with Cleber.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> MAINTAINERS | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6aa54f7f8f..fe1dcd5a76 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2280,11 +2280,18 @@ S: Maintained
> F: include/sysemu/cryptodev*.h
> F: backends/cryptodev*.c
>
> +Python library
> +M: John Snow <jsnow@redhat.com>
> +M: Cleber Rosa <crosa@redhat.com>
> +R: Eduardo Habkost <ehabkost@redhat.com>
> +S: Maintained
> +F: python/*
> +T: git https://gitlab.com/jsnow/qemu.git python
> +
> Python scripts
> M: Eduardo Habkost <ehabkost@redhat.com>
> M: Cleber Rosa <crosa@redhat.com>
> S: Odd fixes
> -F: python/qemu/*py
> F: scripts/*.py
> F: tests/*.py
>
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] MAINTAINERS: Add Python library stanza
2020-07-10 21:57 ` [PATCH 1/1] " John Snow
2020-07-13 8:19 ` Philippe Mathieu-Daudé
@ 2020-07-13 13:35 ` Alex Bennée
2020-07-13 13:59 ` John Snow
2020-07-14 19:15 ` John Snow
2020-07-20 21:06 ` Cleber Rosa
2 siblings, 2 replies; 9+ messages in thread
From: Alex Bennée @ 2020-07-13 13:35 UTC (permalink / raw)
To: John Snow; +Cc: peter.maydell, crosa, qemu-devel, ehabkost
John Snow <jsnow@redhat.com> writes:
> I'm proposing that I split the actual Python library off from the other
> miscellaneous python scripts we have and declare it maintained. Add
> myself as a maintainer of this folder, along with Cleber.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> MAINTAINERS | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6aa54f7f8f..fe1dcd5a76 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2280,11 +2280,18 @@ S: Maintained
> F: include/sysemu/cryptodev*.h
> F: backends/cryptodev*.c
>
> +Python library
> +M: John Snow <jsnow@redhat.com>
> +M: Cleber Rosa <crosa@redhat.com>
> +R: Eduardo Habkost <ehabkost@redhat.com>
> +S: Maintained
> +F: python/*
I don't think that's equivalent to what you drop bellow:
F: drivers/net/ all files in and below drivers/net
F: drivers/net/* all files in drivers/net, but not below
So I think you should drop the *
> +T: git https://gitlab.com/jsnow/qemu.git python
> +
> Python scripts
> M: Eduardo Habkost <ehabkost@redhat.com>
> M: Cleber Rosa <crosa@redhat.com>
> S: Odd fixes
> -F: python/qemu/*py
> F: scripts/*.py
> F: tests/*.py
Otherwise:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/1] MAINTAINERS: Add Python library stanza
2020-07-13 13:35 ` Alex Bennée
@ 2020-07-13 13:59 ` John Snow
2020-07-13 14:03 ` Philippe Mathieu-Daudé
2020-07-13 14:23 ` Eduardo Habkost
2020-07-14 19:15 ` John Snow
1 sibling, 2 replies; 9+ messages in thread
From: John Snow @ 2020-07-13 13:59 UTC (permalink / raw)
To: Alex Bennée; +Cc: peter.maydell, crosa, qemu-devel, ehabkost
On 7/13/20 9:35 AM, Alex Bennée wrote:
>
> John Snow <jsnow@redhat.com> writes:
>
>> I'm proposing that I split the actual Python library off from the other
>> miscellaneous python scripts we have and declare it maintained. Add
>> myself as a maintainer of this folder, along with Cleber.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> ---
>> MAINTAINERS | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 6aa54f7f8f..fe1dcd5a76 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2280,11 +2280,18 @@ S: Maintained
>> F: include/sysemu/cryptodev*.h
>> F: backends/cryptodev*.c
>>
>> +Python library
>> +M: John Snow <jsnow@redhat.com>
>> +M: Cleber Rosa <crosa@redhat.com>
>> +R: Eduardo Habkost <ehabkost@redhat.com>
>> +S: Maintained
>> +F: python/*
>
> I don't think that's equivalent to what you drop bellow:
>
> F: drivers/net/ all files in and below drivers/net
> F: drivers/net/* all files in drivers/net, but not below
>
> So I think you should drop the *
>
I didn't realize that, thanks for correcting it.
>> +T: git https://gitlab.com/jsnow/qemu.git python
>> +
>> Python scripts
>> M: Eduardo Habkost <ehabkost@redhat.com>
>> M: Cleber Rosa <crosa@redhat.com>
>> S: Odd fixes
>> -F: python/qemu/*py
>> F: scripts/*.py
>> F: tests/*.py
>
> Otherwise:
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>
I swear I talked to Cleber and Eduardo before sending this, we'll wait
for them to say hi :)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] MAINTAINERS: Add Python library stanza
2020-07-13 13:59 ` John Snow
@ 2020-07-13 14:03 ` Philippe Mathieu-Daudé
2020-07-13 14:23 ` Eduardo Habkost
1 sibling, 0 replies; 9+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-07-13 14:03 UTC (permalink / raw)
To: John Snow, Alex Bennée; +Cc: peter.maydell, qemu-devel, ehabkost, crosa
On 7/13/20 3:59 PM, John Snow wrote:
> On 7/13/20 9:35 AM, Alex Bennée wrote:
>>
>> John Snow <jsnow@redhat.com> writes:
>>
>>> I'm proposing that I split the actual Python library off from the other
>>> miscellaneous python scripts we have and declare it maintained. Add
>>> myself as a maintainer of this folder, along with Cleber.
>>>
>>> Signed-off-by: John Snow <jsnow@redhat.com>
>>> ---
>>> MAINTAINERS | 9 ++++++++-
>>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 6aa54f7f8f..fe1dcd5a76 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -2280,11 +2280,18 @@ S: Maintained
>>> F: include/sysemu/cryptodev*.h
>>> F: backends/cryptodev*.c
>>>
>>> +Python library
>>> +M: John Snow <jsnow@redhat.com>
>>> +M: Cleber Rosa <crosa@redhat.com>
>>> +R: Eduardo Habkost <ehabkost@redhat.com>
>>> +S: Maintained
>>> +F: python/*
>>
>> I don't think that's equivalent to what you drop bellow:
>>
>> F: drivers/net/ all files in and below drivers/net
>> F: drivers/net/* all files in drivers/net, but not below
>>
>> So I think you should drop the *
I can fix that if I do the next python pull req.
>>
>
> I didn't realize that, thanks for correcting it.
>
>>> +T: git https://gitlab.com/jsnow/qemu.git python
>>> +
>>> Python scripts
>>> M: Eduardo Habkost <ehabkost@redhat.com>
>>> M: Cleber Rosa <crosa@redhat.com>
>>> S: Odd fixes
>>> -F: python/qemu/*py
>>> F: scripts/*.py
>>> F: tests/*.py
>>
>> Otherwise:
>>
>> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>>
>
> I swear I talked to Cleber and Eduardo before sending this, we'll wait
> for them to say hi :)
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] MAINTAINERS: Add Python library stanza
2020-07-13 13:59 ` John Snow
2020-07-13 14:03 ` Philippe Mathieu-Daudé
@ 2020-07-13 14:23 ` Eduardo Habkost
1 sibling, 0 replies; 9+ messages in thread
From: Eduardo Habkost @ 2020-07-13 14:23 UTC (permalink / raw)
To: John Snow; +Cc: peter.maydell, Alex Bennée, qemu-devel, crosa
On Mon, Jul 13, 2020 at 09:59:49AM -0400, John Snow wrote:
>
>
> On 7/13/20 9:35 AM, Alex Bennée wrote:
> >
> > John Snow <jsnow@redhat.com> writes:
> >
> >> I'm proposing that I split the actual Python library off from the other
> >> miscellaneous python scripts we have and declare it maintained. Add
> >> myself as a maintainer of this folder, along with Cleber.
> >>
> >> Signed-off-by: John Snow <jsnow@redhat.com>
> >> ---
> >> MAINTAINERS | 9 ++++++++-
> >> 1 file changed, 8 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index 6aa54f7f8f..fe1dcd5a76 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -2280,11 +2280,18 @@ S: Maintained
> >> F: include/sysemu/cryptodev*.h
> >> F: backends/cryptodev*.c
> >>
> >> +Python library
> >> +M: John Snow <jsnow@redhat.com>
> >> +M: Cleber Rosa <crosa@redhat.com>
> >> +R: Eduardo Habkost <ehabkost@redhat.com>
> >> +S: Maintained
> >> +F: python/*
> >
> > I don't think that's equivalent to what you drop bellow:
> >
> > F: drivers/net/ all files in and below drivers/net
> > F: drivers/net/* all files in drivers/net, but not below
> >
> > So I think you should drop the *
> >
>
> I didn't realize that, thanks for correcting it.
>
> >> +T: git https://gitlab.com/jsnow/qemu.git python
> >> +
> >> Python scripts
> >> M: Eduardo Habkost <ehabkost@redhat.com>
> >> M: Cleber Rosa <crosa@redhat.com>
> >> S: Odd fixes
> >> -F: python/qemu/*py
> >> F: scripts/*.py
> >> F: tests/*.py
> >
> > Otherwise:
> >
> > Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> >
>
> I swear I talked to Cleber and Eduardo before sending this, we'll wait
> for them to say hi :)
You did! And I'm happy to see you are volunteering to replace me
as maintainer on many of those files.
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] MAINTAINERS: Add Python library stanza
2020-07-13 13:35 ` Alex Bennée
2020-07-13 13:59 ` John Snow
@ 2020-07-14 19:15 ` John Snow
1 sibling, 0 replies; 9+ messages in thread
From: John Snow @ 2020-07-14 19:15 UTC (permalink / raw)
To: Alex Bennée; +Cc: peter.maydell, crosa, qemu-devel, ehabkost
On 7/13/20 9:35 AM, Alex Bennée wrote:
>
> John Snow <jsnow@redhat.com> writes:
>
>> I'm proposing that I split the actual Python library off from the other
>> miscellaneous python scripts we have and declare it maintained. Add
>> myself as a maintainer of this folder, along with Cleber.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> ---
>> MAINTAINERS | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 6aa54f7f8f..fe1dcd5a76 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2280,11 +2280,18 @@ S: Maintained
>> F: include/sysemu/cryptodev*.h
>> F: backends/cryptodev*.c
>>
>> +Python library
>> +M: John Snow <jsnow@redhat.com>
>> +M: Cleber Rosa <crosa@redhat.com>
>> +R: Eduardo Habkost <ehabkost@redhat.com>
>> +S: Maintained
>> +F: python/*
>
> I don't think that's equivalent to what you drop bellow:
>
> F: drivers/net/ all files in and below drivers/net
> F: drivers/net/* all files in drivers/net, but not below
>
> So I think you should drop the *
>
>> +T: git https://gitlab.com/jsnow/qemu.git python
>> +
>> Python scripts
>> M: Eduardo Habkost <ehabkost@redhat.com>
>> M: Cleber Rosa <crosa@redhat.com>
>> S: Odd fixes
>> -F: python/qemu/*py
>> F: scripts/*.py
>> F: tests/*.py
>
> Otherwise:
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>
ACK on the edit, I think otherwise I'm still technically waiting for
Cleber to approve this before I would ask for someone to stage it.
--js
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] MAINTAINERS: Add Python library stanza
2020-07-10 21:57 ` [PATCH 1/1] " John Snow
2020-07-13 8:19 ` Philippe Mathieu-Daudé
2020-07-13 13:35 ` Alex Bennée
@ 2020-07-20 21:06 ` Cleber Rosa
2 siblings, 0 replies; 9+ messages in thread
From: Cleber Rosa @ 2020-07-20 21:06 UTC (permalink / raw)
To: John Snow; +Cc: peter.maydell, alex.bennee, qemu-devel, ehabkost
[-- Attachment #1: Type: text/plain, Size: 966 bytes --]
On Fri, Jul 10, 2020 at 05:57:18PM -0400, John Snow wrote:
> I'm proposing that I split the actual Python library off from the other
> miscellaneous python scripts we have and declare it maintained. Add
> myself as a maintainer of this folder, along with Cleber.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> MAINTAINERS | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6aa54f7f8f..fe1dcd5a76 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2280,11 +2280,18 @@ S: Maintained
> F: include/sysemu/cryptodev*.h
> F: backends/cryptodev*.c
>
> +Python library
> +M: John Snow <jsnow@redhat.com>
> +M: Cleber Rosa <crosa@redhat.com>
> +R: Eduardo Habkost <ehabkost@redhat.com>
> +S: Maintained
> +F: python/*
> +T: git https://gitlab.com/jsnow/qemu.git python
> +
Thanks for this, and for that will come next! :)
Ack-by: Cleber Rosa <crosa@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-07-20 21:07 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-10 21:57 [PATCH 0/1] MAINTAINERS: Add Python library stanza John Snow
2020-07-10 21:57 ` [PATCH 1/1] " John Snow
2020-07-13 8:19 ` Philippe Mathieu-Daudé
2020-07-13 13:35 ` Alex Bennée
2020-07-13 13:59 ` John Snow
2020-07-13 14:03 ` Philippe Mathieu-Daudé
2020-07-13 14:23 ` Eduardo Habkost
2020-07-14 19:15 ` John Snow
2020-07-20 21:06 ` Cleber Rosa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).