Re: [PATCH v2 06/15] tests/tcg/tricore: Add macros to create tests and first test 'abs'

["Alex Bennée" <alex.bennee@linaro.org>]

Bastian Koppelmann <kbastian@mail.uni-paderborn.de> writes:

> This kind of tests is inspired by the riscv-tests repository. This adds
> macros that makes it easy to create single instruction self containing
> tests.
>
> It is achieved by macros that create a test sequence for an
> instruction and check for a supplied correct value. If the value is correct the
> next instruction is tested. Otherwise we jump to fail handler that writes is
> test number as a status code back to qemu that then exits on that status code.
> If all tests pass we write back 0 as a status code and exit.
>
> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> ---
>  tests/tcg/configure.sh                    |  7 ++-
>  tests/tcg/tricore/Makefile.softmmu-target |  2 +
>  tests/tcg/tricore/macros.h                | 53 +++++++++++++++++++++++
>  tests/tcg/tricore/test_abs.S              |  8 ++++
>  4 files changed, 69 insertions(+), 1 deletion(-)
>  create mode 100644 tests/tcg/tricore/macros.h
>  create mode 100644 tests/tcg/tricore/test_abs.S
>
> diff --git a/tests/tcg/configure.sh b/tests/tcg/configure.sh
> index 6e8659d488..cd857433d9 100755
> --- a/tests/tcg/configure.sh
> +++ b/tests/tcg/configure.sh
> @@ -85,7 +85,7 @@ for target in $target_list; do
>      xtensa|xtensaeb)
>        arches=xtensa
>        ;;
> -    alpha|cris|hppa|i386|lm32|m68k|openrisc|riscv64|s390x|sh4|sparc64)
> +    alpha|cris|hppa|i386|lm32|m68k|openrisc|riscv64|s390x|sh4|sparc64|tricore)
>        arches=$target
>        ;;
>      *)
> @@ -169,6 +169,11 @@ for target in $target_list; do
>        container_image=debian-sparc64-cross
>        container_cross_cc=sparc64-linux-gnu-gcc
>        ;;
> +    tricore-softmmu)
> +        container_image=debian-tricore-cross
> +        container_cross_as=tricore-as
> +        container_cross_ld=tricore-ld
> +        ;;
>      xtensa*-softmmu)
>        container_image=debian-xtensa-cross

I'd of been tempted to include this with the build infrastructure patch
but whatever...

>  
> diff --git a/tests/tcg/tricore/Makefile.softmmu-target b/tests/tcg/tricore/Makefile.softmmu-target
> index 4a2cd6f218..1b1f220c7c 100644
> --- a/tests/tcg/tricore/Makefile.softmmu-target
> +++ b/tests/tcg/tricore/Makefile.softmmu-target
> @@ -7,6 +7,8 @@ ASFLAGS =
>  
>  QEMU_OPTS += -M tricore_testboard -nographic -kernel
>  
> +TESTS += test_abs.tst
> +

Also you could use wildcards so adding new tests is simpler but anyway:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée