From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: alistair.francis@wdc.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 7/9] cputlb: Partially merge tlb_dyn_init into tlb_init
Date: Mon, 20 Jan 2020 14:33:20 +0000 [thread overview]
Message-ID: <8736ca2o5r.fsf@linaro.org> (raw)
In-Reply-To: <20200109024907.2730-8-richard.henderson@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> Merge into the only caller, but at the same time split
> out tlb_mmu_init to initialize a single tlb entry.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> accel/tcg/cputlb.c | 33 ++++++++++++++++-----------------
> 1 file changed, 16 insertions(+), 17 deletions(-)
>
> diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
> index e60e501334..c7c34b185b 100644
> --- a/accel/tcg/cputlb.c
> +++ b/accel/tcg/cputlb.c
> @@ -97,22 +97,6 @@ static void tlb_window_reset(CPUTLBDesc *desc, int64_t ns,
> desc->window_max_entries = max_entries;
> }
>
> -static void tlb_dyn_init(CPUArchState *env)
> -{
> - int i;
> -
> - for (i = 0; i < NB_MMU_MODES; i++) {
> - CPUTLBDesc *desc = &env_tlb(env)->d[i];
> - size_t n_entries = 1 << CPU_TLB_DYN_DEFAULT_BITS;
> -
> - tlb_window_reset(desc, get_clock_realtime(), 0);
> - desc->n_used_entries = 0;
> - env_tlb(env)->f[i].mask = (n_entries - 1) << CPU_TLB_ENTRY_BITS;
> - env_tlb(env)->f[i].table = g_new(CPUTLBEntry, n_entries);
> - env_tlb(env)->d[i].iotlb = g_new(CPUIOTLBEntry, n_entries);
> - }
> -}
> -
> /**
> * tlb_mmu_resize_locked() - perform TLB resize bookkeeping; resize if necessary
> * @desc: The CPUTLBDesc portion of the TLB
> @@ -247,6 +231,17 @@ static void tlb_flush_one_mmuidx_locked(CPUArchState *env, int mmu_idx)
> tlb_mmu_flush_locked(desc, fast);
> }
>
> +static void tlb_mmu_init(CPUTLBDesc *desc, CPUTLBDescFast *fast, int64_t now)
> +{
> + size_t n_entries = 1 << CPU_TLB_DYN_DEFAULT_BITS;
> +
> + tlb_window_reset(desc, now, 0);
> + desc->n_used_entries = 0;
> + fast->mask = (n_entries - 1) << CPU_TLB_ENTRY_BITS;
> + fast->table = g_new(CPUTLBEntry, n_entries);
> + desc->iotlb = g_new(CPUIOTLBEntry, n_entries);
> +}
> +
> static inline void tlb_n_used_entries_inc(CPUArchState *env, uintptr_t mmu_idx)
> {
> env_tlb(env)->d[mmu_idx].n_used_entries++;
> @@ -260,13 +255,17 @@ static inline void tlb_n_used_entries_dec(CPUArchState *env, uintptr_t mmu_idx)
> void tlb_init(CPUState *cpu)
> {
> CPUArchState *env = cpu->env_ptr;
> + int64_t now = get_clock_realtime();
> + int i;
>
> qemu_spin_init(&env_tlb(env)->c.lock);
>
> /* Ensure that cpu_reset performs a full flush. */
> env_tlb(env)->c.dirty = ALL_MMUIDX_BITS;
>
> - tlb_dyn_init(env);
> + for (i = 0; i < NB_MMU_MODES; i++) {
> + tlb_mmu_init(&env_tlb(env)->d[i], &env_tlb(env)->f[i], now);
> + }
> }
>
> /* flush_all_helper: run fn across all cpus
--
Alex Bennée
next prev parent reply other threads:[~2020-01-20 14:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 2:48 [PATCH 0/9] cputlb: Various cleanups Richard Henderson
2020-01-09 2:48 ` [PATCH 1/9] cputlb: Merge tlb_table_flush_by_mmuidx into tlb_flush_one_mmuidx_locked Richard Henderson
2020-01-20 0:34 ` Alistair Francis
2020-01-20 13:34 ` Alex Bennée
2020-01-09 2:49 ` [PATCH 2/9] cputlb: Make tlb_n_entries private to cputlb.c Richard Henderson
2020-01-20 0:36 ` Alistair Francis
2020-01-20 8:53 ` Philippe Mathieu-Daudé
2020-01-20 13:34 ` Alex Bennée
2020-01-09 2:49 ` [PATCH 3/9] cputlb: Pass CPUTLBDescFast to tlb_n_entries and sizeof_tlb Richard Henderson
2020-01-20 0:37 ` Alistair Francis
2020-01-20 8:54 ` Philippe Mathieu-Daudé
2020-01-20 13:36 ` Alex Bennée
2020-01-20 13:39 ` Alex Bennée
2020-01-09 2:49 ` [PATCH 4/9] cputlb: Hoist tlb portions in tlb_mmu_resize_locked Richard Henderson
2020-01-20 8:58 ` Philippe Mathieu-Daudé
2020-01-20 12:05 ` Alistair Francis
2020-01-20 13:40 ` Alex Bennée
2020-01-09 2:49 ` [PATCH 5/9] cputlb: Hoist tlb portions in tlb_flush_one_mmuidx_locked Richard Henderson
2020-01-20 8:58 ` Philippe Mathieu-Daudé
2020-01-20 13:41 ` Alex Bennée
2020-01-20 22:56 ` Alistair Francis
2020-01-09 2:49 ` [PATCH 6/9] cputlb: Split out tlb_mmu_flush_locked Richard Henderson
2020-01-20 8:59 ` Philippe Mathieu-Daudé
2020-01-20 13:41 ` Alex Bennée
2020-01-20 22:58 ` Alistair Francis
2020-01-09 2:49 ` [PATCH 7/9] cputlb: Partially merge tlb_dyn_init into tlb_init Richard Henderson
2020-01-20 9:01 ` Philippe Mathieu-Daudé
2020-01-20 14:33 ` Alex Bennée [this message]
2020-01-20 23:00 ` Alistair Francis
2020-01-09 2:49 ` [PATCH 8/9] cputlb: Initialize tlbs as flushed Richard Henderson
2020-01-20 14:33 ` Alex Bennée
2020-01-20 23:01 ` Alistair Francis
2020-01-09 2:49 ` [PATCH 9/9] cputlb: Hoist timestamp outside of loops over tlbs Richard Henderson
2020-01-20 9:02 ` Philippe Mathieu-Daudé
2020-01-20 14:36 ` Alex Bennée
2020-01-20 23:02 ` Alistair Francis
2020-01-20 23:03 ` [PATCH 0/9] cputlb: Various cleanups Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736ca2o5r.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).