From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9Wfq-0001WE-KU for qemu-devel@nongnu.org; Tue, 31 Oct 2017 09:33:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9Wfm-0004HU-Hv for qemu-devel@nongnu.org; Tue, 31 Oct 2017 09:33:46 -0400 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:46517) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e9Wfm-0004Gv-B0 for qemu-devel@nongnu.org; Tue, 31 Oct 2017 09:33:42 -0400 Received: by mail-wm0-x22a.google.com with SMTP id m72so22646071wmc.1 for ; Tue, 31 Oct 2017 06:33:41 -0700 (PDT) References: <20171031122824.25686-1-f4bug@amsat.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <20171031122824.25686-1-f4bug@amsat.org> Date: Tue, 31 Oct 2017 13:33:39 +0000 Message-ID: <87375zigr0.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] docker: add python stdlib dependency (required by keycodemapdb) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Fam Zheng , Gerd Hoffmann , "Daniel P . Berrange" , qemu-devel@nongnu.org, Peter Maydell , Debian QEMU Team Philippe Mathieu-Daud=C3=A9 writes: > Since 927128222b0a QEMU depends of keycodemapdb, which uses the python 'c= sv' > module from stdlib to parse keymaps.csv. > > Without this package the build fails: > > GEN ui/input-keymap-linux-to-qcode.c > Traceback (most recent call last): > File "ui/keycodemapdb/tools/keymap-gen", line 15, in > import csv > ImportError: No module named csv > GEN ui/input-keymap-qcode-to-qnum.c > Traceback (most recent call last): > File "ui/keycodemapdb/tools/keymap-gen", line 15, in > import csv > ImportError: No module named csv > [...] > CC ui/input-keymap.o > ui/input-keymap.c:8:44: fatal error: ui/input-keymap-linux-to-qcode.c: = No such file or directory > make: *** [ui/input-keymap.o] Error 1 > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > this might affect native MinGW builds. > > (master broken since a4faa26857694fa87d96d15ad5b6afa8fbc2c900) It did - interesting that the python breakage doesn't halt the build there and then. Applied to travis/next > > we didn't notice Shippable failures: > https://app.shippable.com/github/qemu/qemu/runs/501/summary/console and n= ext > > tests/docker/dockerfiles/debian8-mxe.docker | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/docker/dockerfiles/debian8-mxe.docker b/tests/docker/d= ockerfiles/debian8-mxe.docker > index 7bf1b59e54..9b8e577b03 100644 > --- a/tests/docker/dockerfiles/debian8-mxe.docker > +++ b/tests/docker/dockerfiles/debian8-mxe.docker > @@ -13,6 +13,7 @@ RUN apt-key adv --keyserver keyserver.ubuntu.com --recv= -keys D43A795B73B16ABE964 > RUN apt-get update > RUN DEBIAN_FRONTEND=3Dnoninteractive eatmydata \ > apt-get install -y --no-install-recommends \ > + libpython2.7-stdlib \ > $(apt-get -s install -y --no-install-recommends gw32.shared-ming= w-w64 gw32.shared-mingw-w64 | egrep "^Inst mxe-x86-64-unknown-" | cut -d\ = -f2) > > ENV PATH $PATH:/usr/lib/mxe/usr/bin/ -- Alex Benn=C3=A9e