From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <rth@twiddle.net>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] (RFC) remove the GThread coroutine implementation
Date: Sun, 30 Apr 2017 07:20:54 +0100 [thread overview]
Message-ID: <8737cq4drt.fsf@linaro.org> (raw)
In-Reply-To: <a3f22a00-1f2e-6d22-f2a2-edc233cd6c64@twiddle.net>
Richard Henderson <rth@twiddle.net> writes:
> On 04/28/2017 02:24 PM, Daniel P. Berrange wrote:
>> At the 2016 summit it was suggested that we delete the GThread
>> coroutine impl since it is not fully functional, and you can
>> debug the ucontext impl with our GDB helper script.
>>
>> I don't recall the subject being raised again since the summit
>> so here's a proposal to delete the GThread impl, as a way to
>> trigger input from anyone who thinks we need to keep it......
>
> The last time this was mentioned, the reason that we were keeping it
> was to make clang's thread-sanitizer module happy. Whether we can
> still find relevant bugs with that, I don't know.
It's been a while since I last did a ThreadSanitizer run. The correct
fix is teaching the sanitizer about set context so we can use our normal
build - however this has been at the bottom of a pile for such a long
time.
--
Alex Bennée
next prev parent reply other threads:[~2017-04-30 6:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 12:24 [Qemu-devel] [PATCH] (RFC) remove the GThread coroutine implementation Daniel P. Berrange
2017-04-28 12:24 ` [Qemu-devel] [PATCH] coroutine: remove GThread implementation Daniel P. Berrange
2017-04-28 15:39 ` [Qemu-devel] [PATCH] (RFC) remove the GThread coroutine implementation Stefan Hajnoczi
2017-04-29 9:28 ` Richard Henderson
2017-04-30 6:20 ` Alex Bennée [this message]
2017-05-02 14:09 ` Stefan Hajnoczi
2017-05-02 14:36 ` Alex Bennée
2017-05-03 14:03 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737cq4drt.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).