From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, "Hervé Poussineau" <hpoussin@reactos.org>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] ps2: Fix lost scancodes by recent changes
Date: Sat, 24 Dec 2016 08:33:51 +0900 [thread overview]
Message-ID: <8737heb4ps.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <8eb87c0e-ba00-e748-8cec-fa089403e13c@redhat.com> (Eric Blake's message of "Fri, 23 Dec 2016 15:58:07 -0600")
Eric Blake <eblake@redhat.com> writes:
> On 12/23/2016 07:00 AM, OGAWA Hirofumi wrote:
>>
>> With "ps2: use QEMU qcodes instead of scancodes", key handling was
>> changed to qcode base. But all scancodes are not converted to new one.
>>
>> This adds some missing qcodes what I found in using.
>>
>> Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
>> ---
>>
>
>> +++ qemu-hirofumi/qapi-schema.json 2016-12-23 21:14:59.840729469 +0900
>> @@ -3642,7 +3642,8 @@
>> 'kp_9', 'less', 'f11', 'f12', 'print', 'home', 'pgup', 'pgdn', 'end',
>> 'left', 'up', 'down', 'right', 'insert', 'delete', 'stop', 'again',
>> 'props', 'undo', 'front', 'copy', 'open', 'paste', 'find', 'cut',
>> - 'lf', 'help', 'meta_l', 'meta_r', 'compose', 'pause', 'ro',
>> + 'lf', 'help', 'meta_l', 'meta_r', 'compose', 'pause',
>> + 'ro', 'hiragana', 'henkan', 'yen',
>> 'kp_comma', 'kp_equals', 'power' ] }
>
> Missing documentation (including a 'since 2.9' designation) for the new
> enum members.
Thanks for pointing out.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2016-12-23 23:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 13:00 [Qemu-devel] [PATCH] ps2: Fix lost scancodes by recent changes OGAWA Hirofumi
2016-12-23 20:58 ` Hervé Poussineau
2016-12-23 22:49 ` OGAWA Hirofumi
2016-12-27 14:27 ` Hervé Poussineau
2016-12-27 19:49 ` OGAWA Hirofumi
2016-12-27 19:55 ` [Qemu-devel] [PATCH v3] " OGAWA Hirofumi
2016-12-27 20:11 ` Hervé Poussineau
2017-01-04 8:50 ` Gerd Hoffmann
2017-01-04 17:59 ` Hervé Poussineau
2017-01-04 21:11 ` OGAWA Hirofumi
2017-01-05 8:12 ` Gerd Hoffmann
2017-01-05 8:45 ` OGAWA Hirofumi
2016-12-23 21:58 ` [Qemu-devel] [PATCH] " Eric Blake
2016-12-23 23:33 ` OGAWA Hirofumi [this message]
2016-12-23 23:36 ` [Qemu-devel] [PATCH v2] " OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737heb4ps.fsf@mail.parknet.co.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=eblake@redhat.com \
--cc=hpoussin@reactos.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).