From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c58d4-0007T6-60 for qemu-devel@nongnu.org; Fri, 11 Nov 2016 05:00:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c58d1-0001ER-5A for qemu-devel@nongnu.org; Fri, 11 Nov 2016 05:00:14 -0500 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:36593) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c58d0-0001BZ-Mt for qemu-devel@nongnu.org; Fri, 11 Nov 2016 05:00:11 -0500 Received: by mail-wm0-x22e.google.com with SMTP id g23so89334313wme.1 for ; Fri, 11 Nov 2016 02:00:10 -0800 (PST) References: <1478798481-25030-1-git-send-email-drjones@redhat.com> <1478798481-25030-11-git-send-email-drjones@redhat.com> <874m3f8621.fsf@linaro.org> <4d1964d4-6540-3df6-8193-6dac3efa7d5c@arm.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <4d1964d4-6540-3df6-8193-6dac3efa7d5c@arm.com> Date: Fri, 11 Nov 2016 10:00:07 +0000 Message-ID: <8737iy8hg8.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [kvm-unit-tests PATCH v5 10/11] arm/arm64: gicv3: add an IPI test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andre Przywara Cc: Andrew Jones , kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, qemu-devel@nongnu.org, qemu-arm@nongnu.org, pbonzini@redhat.com, peter.maydell@linaro.org, marc.zyngier@arm.com, eric.auger@redhat.com, christoffer.dall@linaro.org Andre Przywara writes: > Hi, > > On 10/11/16 19:53, Alex Bennée wrote: > > .... >> So I was re-basing my kvm-unit-tests against your GIC rework and found >> myself copy and pasting a bunch of this into my tests that fire IRQs. > > So I take it you are working on (or already have) code to test SPIs, > probably via GICD_ISPENDR? > Just asking because I was thinking about going there and thus could save > my time if you are on it already... In my case I wanted to trigger SPIs to exercise my TCG tests for MTTCG: https://github.com/stsquad/kvm-unit-tests/blob/mttcg/current-tests-v6/arm/tcg-test.c#L113 >> That makes me think the abstraction should be in the library code so >> other tests can fiddle with sending IRQs. > > ...because I was wondering the same. To answer Andrew's question from the other post I would be happy with a common: gic_enable gic_send_spi(cpu, irq) gic_irq_ack() which returns the iar. > > Cheers, > Andre. -- Alex Bennée