From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW02Z-0005e5-LH for qemu-devel@nongnu.org; Thu, 12 Mar 2015 06:08:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YW02Q-0008I8-H5 for qemu-devel@nongnu.org; Thu, 12 Mar 2015 06:08:31 -0400 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:36435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW02P-0008HN-Tp for qemu-devel@nongnu.org; Thu, 12 Mar 2015 06:08:22 -0400 Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 12 Mar 2015 20:08:15 +1000 From: "Aneesh Kumar K.V" In-Reply-To: <1426142172-30886-1-git-send-email-mjt@msgid.tls.msk.ru> References: <1426142172-30886-1-git-send-email-mjt@msgid.tls.msk.ru> Date: Thu, 12 Mar 2015 15:37:09 +0530 Message-ID: <87385abkc2.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2] 9pfs-proxy: tiny cleanups in proxy_pwritev and proxy_preadv List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org Michael Tokarev writes: > Don't compare syscall return with -1, use "<0" condition. > Don't introduce useless local variables when we already > have similar variable > Rename local variable to be consistent with other usages > Finally make the two methods, read and write, to be similar to each other > > Signed-off-by: Michael Tokarev Applied. Thanks -aneesh