From: Anthony Liguori <aliguori@us.ibm.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Jordan Justen <jljusten@gmail.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] gtk: Fix accelerator filtering
Date: Wed, 17 Jul 2013 08:02:11 -0500 [thread overview]
Message-ID: <8738rdwd9o.fsf@codemonkey.ws> (raw)
In-Reply-To: <51E63FA1.8090001@web.de>
Jan Kiszka <jan.kiszka@web.de> writes:
> On 2013-05-08 00:42, Jan Kiszka wrote:
>> On 2013-05-07 23:03, Jordan Justen wrote:
>> Yeah, this bug should really be fixed in some way before 1.5 is released
>> because GTK will be default. Anthony, what is the status of your
>> experiments with alternative solutions?
>
> Re-ping on this, now for 1.6 (with the option to backport the fix).
>
> What defines the modifiers to be used for the accelerators? Is there an
> interface to query them (to avoid my original hard-coding)?
I hate to let the bug fester for another release although this fix
breaks accelerator remapping. I guess that's better than nothing so
please rebase. I'll try to fix it properly on top of your patch.
Regards,
Anthony Liguori
>
> Jan
next prev parent reply other threads:[~2013-07-17 13:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1361367806-4599-1-git-send-email-aliguori@us.ibm.com>
[not found] ` <1361367806-4599-10-git-send-email-aliguori@us.ibm.com>
[not found] ` <5127B788.40701@siemens.com>
[not found] ` <5127BBC1.5070607@siemens.com>
[not found] ` <512B7B8B.1000402@siemens.com>
[not found] ` <87zjys9zcv.fsf@codemonkey.ws>
[not found] ` <512B86E7.80603@siemens.com>
2013-03-24 18:06 ` [Qemu-devel] [PATCH v2] gtk: Fix accelerator filtering Jan Kiszka
2013-03-25 12:51 ` Anthony Liguori
2013-05-07 21:03 ` Jordan Justen
2013-05-07 22:42 ` Jan Kiszka
2013-07-17 6:54 ` Jan Kiszka
2013-07-17 13:02 ` Anthony Liguori [this message]
2013-07-22 7:04 ` [Qemu-devel] [PATCH v3] " Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738rdwd9o.fsf@codemonkey.ws \
--to=aliguori@us.ibm.com \
--cc=jan.kiszka@web.de \
--cc=jljusten@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).