From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56042)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1UzRRB-0001S2-CE
	for qemu-devel@nongnu.org; Wed, 17 Jul 2013 09:06:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1UzRRA-0005it-4W
	for qemu-devel@nongnu.org; Wed, 17 Jul 2013 09:06:33 -0400
Received: from e8.ny.us.ibm.com ([32.97.182.138]:35822)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1UzRR9-0005in-Vq
	for qemu-devel@nongnu.org; Wed, 17 Jul 2013 09:06:32 -0400
Received: from /spool/local
	by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aliguori@us.ibm.com>;
	Wed, 17 Jul 2013 14:06:31 +0100
Received: from d01relay06.pok.ibm.com (d01relay06.pok.ibm.com [9.56.227.116])
	by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 4E616C90046
	for <qemu-devel@nongnu.org>; Wed, 17 Jul 2013 09:06:27 -0400 (EDT)
Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169])
	by d01relay06.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r6HD5wXS27787400
	for <qemu-devel@nongnu.org>; Wed, 17 Jul 2013 09:06:28 -0400
Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1])
	by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id r6HD2MNF031434
	for <qemu-devel@nongnu.org>; Wed, 17 Jul 2013 07:02:23 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
In-Reply-To: <51E63FA1.8090001@web.de>
References: <1361367806-4599-1-git-send-email-aliguori@us.ibm.com>
	<1361367806-4599-10-git-send-email-aliguori@us.ibm.com>
	<5127B788.40701@siemens.com> <5127BBC1.5070607@siemens.com>
	<512B7B8B.1000402@siemens.com> <87zjys9zcv.fsf@codemonkey.ws>
	<512B86E7.80603@siemens.com> <514F40A2.6000202@web.de>
	<CAFe8ug-j+Ea-BWpw3tVu6zwTFaUmzfTTLe6gVbUs_tpp4r1mEw@mail.gmail.com>
	<5189836B.2080000@web.de> <51E63FA1.8090001@web.de>
Date: Wed, 17 Jul 2013 08:02:11 -0500
Message-ID: <8738rdwd9o.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH v2] gtk: Fix accelerator filtering
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Jordan Justen <jljusten@gmail.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Jan Kiszka <jan.kiszka@web.de> writes:

> On 2013-05-08 00:42, Jan Kiszka wrote:
>> On 2013-05-07 23:03, Jordan Justen wrote:
>> Yeah, this bug should really be fixed in some way before 1.5 is released
>> because GTK will be default. Anthony, what is the status of your
>> experiments with alternative solutions?
>
> Re-ping on this, now for 1.6 (with the option to backport the fix).
>
> What defines the modifiers to be used for the accelerators? Is there an
> interface to query them (to avoid my original hard-coding)?

I hate to let the bug fester for another release although this fix
breaks accelerator remapping.  I guess that's better than nothing so
please rebase.  I'll try to fix it properly on top of your patch.

Regards,

Anthony Liguori

>
> Jan