From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpQMz-0006fX-M6 for qemu-devel@nongnu.org; Wed, 19 Jun 2013 17:56:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpQMy-0006ci-TO for qemu-devel@nongnu.org; Wed, 19 Jun 2013 17:56:49 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:35867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpQMy-0006cY-NE for qemu-devel@nongnu.org; Wed, 19 Jun 2013 17:56:48 -0400 Received: from /spool/local by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 19 Jun 2013 15:56:47 -0600 From: Anthony Liguori In-Reply-To: <86C51EF8-1C90-458D-BD9E-4D4D71A04E85@suse.de> References: <1371674435-14973-1-git-send-email-aliguori@us.ibm.com> <1371674435-14973-12-git-send-email-aliguori@us.ibm.com> <86C51EF8-1C90-458D-BD9E-4D4D71A04E85@suse.de> Date: Wed, 19 Jun 2013 16:56:24 -0500 Message-ID: <8738sdhiif.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 11/12] spapr-vio: pass type to spapr_vio_find_by_reg() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, Paul Mackerras , qemu-devel@nongnu.org, Andreas Faerber Alexander Graf writes: > On 19.06.2013, at 22:40, Anthony Liguori wrote: > >> Today if an invalid hcall is made to an otherwise valid device we >> abort due to QOM casting. This adds a parameter to find_by_reg() >> to indicate which type of device we're looking for. > > This should also adjust the hack to only match reg=0 for > TYPE_VIO_SPAPR_VTY_DEVICE, no? Yup, that'll result in a bad cast otherwise. Nice catch. I'll respin. Regards, Anthony Liguori > > > Alex