From: Anthony Liguori <aliguori@us.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Gerd Hoffman <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] gtk: don't use g_object_ref on GdkCursor
Date: Mon, 03 Jun 2013 16:10:54 -0500 [thread overview]
Message-ID: <8738syoq75.fsf@codemonkey.ws> (raw)
In-Reply-To: <CAFEAcA9b0hfQiPtAMOXrtb5LVL8Cx5PRf-ZeABzVgfZBN0m8-w@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 3 June 2013 21:39, Anthony Liguori <aliguori@us.ibm.com> wrote:
>> It's not a GObject.
>>
>> Cc: Gerd Hoffman <kraxel@redhat.com>
>> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>> ---
>> ui/gtk.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ui/gtk.c b/ui/gtk.c
>> index 8dc9041..3bc2842 100644
>> --- a/ui/gtk.c
>> +++ b/ui/gtk.c
>> @@ -377,7 +377,7 @@ static void gd_cursor_define(DisplayChangeListener *dcl,
>> pixbuf, c->hot_x, c->hot_y);
>> gdk_window_set_cursor(gtk_widget_get_window(s->drawing_area), cursor);
>> g_object_unref(pixbuf);
>> - g_object_unref(cursor);
>> + gdk_cursor_unref(cursor);
>
> Function name in subject doesn't match code change :-)
Doh, ack.
Regards,
Anthony Liguori
>
> -- PMM
prev parent reply other threads:[~2013-06-03 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 20:39 [Qemu-devel] [PATCH] gtk: don't use g_object_ref on GdkCursor Anthony Liguori
2013-06-03 20:50 ` Peter Maydell
2013-06-03 21:10 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738syoq75.fsf@codemonkey.ws \
--to=aliguori@us.ibm.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).