From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsKUG-0002kH-CP for qemu-devel@nongnu.org; Mon, 07 Jan 2013 16:44:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TsKUF-0006wn-Bx for qemu-devel@nongnu.org; Mon, 07 Jan 2013 16:44:04 -0500 Received: from e9.ny.us.ibm.com ([32.97.182.139]:52367) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TsKUF-0006wV-8K for qemu-devel@nongnu.org; Mon, 07 Jan 2013 16:44:03 -0500 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 Jan 2013 16:44:02 -0500 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 56B6438C8045 for ; Mon, 7 Jan 2013 16:43:59 -0500 (EST) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r07Lhw58272278 for ; Mon, 7 Jan 2013 16:43:58 -0500 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r07LhVKs014031 for ; Mon, 7 Jan 2013 14:43:34 -0700 From: Anthony Liguori In-Reply-To: <50EB32BB.5040302@de.ibm.com> References: <1355760006-891-1-git-send-email-borntraeger@de.ibm.com> <874nisvlfv.fsf@codemonkey.ws> <50EB32BB.5040302@de.ibm.com> Date: Mon, 07 Jan 2013 15:43:23 -0600 Message-ID: <8738yc1xfo.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] qdev: obey no_user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: "qemu-devel@nongnu.org" , Andreas =?utf-8?Q?F?= =?utf-8?Q?=C3=A4rber?= Christian Borntraeger writes: > On 07/01/13 20:32, Anthony Liguori wrote: >> Christian Borntraeger writes: >> >>> since >>> >>> commit 18b6dade8c0799c48f5c5e124b8c407cd5e22e96 >>> qdev: refactor device creation to allow bus_info to be set only in class >>> >>> A user can specify a device that is no_user. >>> For example on my i386 box, I can add a 2nd kvmvapic device. >>> >>> This patch checks for no-user and rejects the device_add. >>> >>> Signed-off-by: Christian Borntraeger >> >> I specifically broke this when QOM was introduced because no_user >> precludes a management tool from constructing a machine directlt. > > Breaking it but leaving it in the code doesnt seem to be the right thing. > The commit message from 18b6dade doesnt give any hint that this is now > broken and nobody audited the callers of no_user that they handle things > gracefully. > > So whats the plan? Totally remove no_user tree-wide? One of the reasons I left no_user is that it's exposed to users via 'info qdm'. I don't think it matters anymore so we can probably safely remove it. Regards, Anthony Liguori > > Christian