From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TazJK-0000jA-LN for qemu-devel@nongnu.org; Tue, 20 Nov 2012 20:41:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TazJJ-0000JS-FF for qemu-devel@nongnu.org; Tue, 20 Nov 2012 20:41:06 -0500 Received: from mail-ob0-f173.google.com ([209.85.214.173]:64427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TazJJ-0000In-AN for qemu-devel@nongnu.org; Tue, 20 Nov 2012 20:41:05 -0500 Received: by mail-ob0-f173.google.com with SMTP id x4so6170949obh.4 for ; Tue, 20 Nov 2012 17:41:04 -0800 (PST) From: Anthony Liguori In-Reply-To: <690764e834edc670bfef47b469825b684f5a54f6.1353421334.git.amit.shah@redhat.com> References: <690764e834edc670bfef47b469825b684f5a54f6.1353421334.git.amit.shah@redhat.com> Date: Tue, 20 Nov 2012 19:41:00 -0600 Message-ID: <873903lolv.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 2/4] virtio-rng: remove extra request for entropy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: Paolo Bonzini , qemu list Amit Shah writes: > If we got fewer bytes from the backend than requested, don't poke the > backend for more bytes; the guest will ask for more (or if the guest has > already asked for more, the backend knows about it via handle_input()). > > Signed-off-by: Amit Shah Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > hw/virtio-rng.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c > index 6c49bb2..cf5a8ff 100644 > --- a/hw/virtio-rng.c > +++ b/hw/virtio-rng.c > @@ -80,13 +80,6 @@ static void chr_read(void *opaque, const void *buf, size_t size) > virtqueue_push(vrng->vq, &elem, len); > } > virtio_notify(&vrng->vdev, vrng->vq); > - > - /* > - * Lastly, if we had multiple elems queued by the guest, and we > - * didn't have enough data to fill them all, indicate we want more > - * data. > - */ > - virtio_rng_process(vrng); > } > > static void virtio_rng_process(VirtIORNG *vrng) > -- > 1.8.0