From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJQB0-0002dZ-9q for qemu-devel@nongnu.org; Wed, 03 Oct 2012 10:44:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJQAq-0002PQ-GJ for qemu-devel@nongnu.org; Wed, 03 Oct 2012 10:43:54 -0400 Received: from e38.co.us.ibm.com ([32.97.110.159]:37971) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJQAq-0002PM-2F for qemu-devel@nongnu.org; Wed, 03 Oct 2012 10:43:44 -0400 Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 3 Oct 2012 08:43:42 -0600 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 583771FF003C for ; Wed, 3 Oct 2012 08:43:32 -0600 (MDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q93EhSwl135688 for ; Wed, 3 Oct 2012 08:43:32 -0600 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q93Ej6KO030106 for ; Wed, 3 Oct 2012 08:45:06 -0600 From: Anthony Liguori In-Reply-To: <20121003105509.614535373@amt.cnet> References: <20121003105255.972669952@amt.cnet> <20121003105509.614535373@amt.cnet> Date: Wed, 03 Oct 2012 09:43:20 -0500 Message-ID: <87391vhb07.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [patch 5/6] Emulate qemu-kvms drive parameter boot=on|off List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcelo Tosatti , qemu-devel@nongnu.org, Gerd Hoffmann Cc: kvm@vger.kernel.org Marcelo Tosatti writes: > Commit 841280b6c224ea2c6edc2f5afc2add513c85181d from qemu-kvm.git. > > From: Jan Kiszka > > We do not want to maintain this option forever. It will be removed after > a grace period of a few releases. So warn the user that this option has > no effect and will become invalid soon. > > Signed-off-by: Marcelo Tosatti Reviewed-by: Anthony Liguori Regards, Anthony Liguori > > Index: qemu-compat-kvm/blockdev.c > =================================================================== > --- qemu-compat-kvm.orig/blockdev.c > +++ qemu-compat-kvm/blockdev.c > @@ -432,6 +432,12 @@ DriveInfo *drive_init(QemuOpts *opts, in > return NULL; > } > > + if (qemu_opt_get(opts, "boot") != NULL) { > + fprintf(stderr, "qemu-kvm: boot=on|off is deprecated and will be " > + "ignored. Future versions will reject this parameter. Please " > + "update your scripts.\n"); > + } > + > on_write_error = BLOCK_ERR_STOP_ENOSPC; > if ((buf = qemu_opt_get(opts, "werror")) != NULL) { > if (type != IF_IDE && type != IF_SCSI && type != IF_VIRTIO && type != IF_NONE) { > Index: qemu-compat-kvm/qemu-config.c > =================================================================== > --- qemu-compat-kvm.orig/qemu-config.c > +++ qemu-compat-kvm/qemu-config.c > @@ -114,6 +114,10 @@ static QemuOptsList qemu_drive_opts = { > .name = "copy-on-read", > .type = QEMU_OPT_BOOL, > .help = "copy read data from backing file into image file", > + },{ > + .name = "boot", > + .type = QEMU_OPT_BOOL, > + .help = "(deprecated, ignored)", > }, > { /* end of list */ } > }, > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html