From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58115)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TGcyf-0006Y9-M0
	for qemu-devel@nongnu.org; Tue, 25 Sep 2012 17:47:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TGcyd-0005JF-QU
	for qemu-devel@nongnu.org; Tue, 25 Sep 2012 17:47:37 -0400
Received: from mail-ob0-f173.google.com ([209.85.214.173]:58570)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1TGcyd-0005Ik-LT
	for qemu-devel@nongnu.org; Tue, 25 Sep 2012 17:47:35 -0400
Received: by obbta14 with SMTP id ta14so6680980obb.4
	for <qemu-devel@nongnu.org>; Tue, 25 Sep 2012 14:47:34 -0700 (PDT)
From: Anthony Liguori <anthony@codemonkey.ws>
In-Reply-To: <1348577763-12920-5-git-send-email-pbonzini@redhat.com>
References: <1348577763-12920-1-git-send-email-pbonzini@redhat.com>
	<1348577763-12920-5-git-send-email-pbonzini@redhat.com>
Date: Tue, 25 Sep 2012 16:47:31 -0500
Message-ID: <873925ojv0.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 04/17] aio: change qemu_aio_set_fd_handler
	to return void
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

Paolo Bonzini <pbonzini@redhat.com> writes:

> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

> ---
>  aio.c      | 12 +++++-------
>  qemu-aio.h | 10 +++++-----
>  2 file modificati, 10 inserzioni(+), 12 rimozioni(-)
>
> diff --git a/aio.c b/aio.c
> index c738a4e..e062aab 100644
> --- a/aio.c
> +++ b/aio.c
> @@ -53,11 +53,11 @@ static AioHandler *find_aio_handler(int fd)
>      return NULL;
>  }
>  
> -int qemu_aio_set_fd_handler(int fd,
> -                            IOHandler *io_read,
> -                            IOHandler *io_write,
> -                            AioFlushHandler *io_flush,
> -                            void *opaque)
> +void qemu_aio_set_fd_handler(int fd,
> +                             IOHandler *io_read,
> +                             IOHandler *io_write,
> +                             AioFlushHandler *io_flush,
> +                             void *opaque)
>  {
>      AioHandler *node;
>  
> @@ -93,8 +93,6 @@ int qemu_aio_set_fd_handler(int fd,
>      }
>  
>      qemu_set_fd_handler2(fd, NULL, io_read, io_write, opaque);
> -
> -    return 0;
>  }
>  
>  void qemu_aio_flush(void)
> diff --git a/qemu-aio.h b/qemu-aio.h
> index bfdd35f..27a7e21 100644
> --- a/qemu-aio.h
> +++ b/qemu-aio.h
> @@ -60,10 +60,10 @@ bool qemu_aio_wait(void);
>   * Code that invokes AIO completion functions should rely on this function
>   * instead of qemu_set_fd_handler[2].
>   */
> -int qemu_aio_set_fd_handler(int fd,
> -                            IOHandler *io_read,
> -                            IOHandler *io_write,
> -                            AioFlushHandler *io_flush,
> -                            void *opaque);
> +void qemu_aio_set_fd_handler(int fd,
> +                             IOHandler *io_read,
> +                             IOHandler *io_write,
> +                             AioFlushHandler *io_flush,
> +                             void *opaque);
>  
>  #endif
> -- 
> 1.7.12