From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGqtU-0002Wu-9z for qemu-devel@nongnu.org; Wed, 26 Sep 2012 08:39:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGqtO-0002bh-Ku for qemu-devel@nongnu.org; Wed, 26 Sep 2012 08:39:12 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:38928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGqtO-0002bd-DL for qemu-devel@nongnu.org; Wed, 26 Sep 2012 08:39:06 -0400 Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 26 Sep 2012 06:39:05 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 4DF5119D803E for ; Wed, 26 Sep 2012 06:39:02 -0600 (MDT) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q8QCd11x243598 for ; Wed, 26 Sep 2012 06:39:01 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q8QCd0bs023555 for ; Wed, 26 Sep 2012 06:39:01 -0600 From: Anthony Liguori In-Reply-To: <1346879185-19299-1-git-send-email-imammedo@redhat.com> References: <1346879185-19299-1-git-send-email-imammedo@redhat.com> Date: Wed, 26 Sep 2012 07:38:55 -0500 Message-ID: <873925rmao.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 0/5 v3] convert system_powerdown command to notifiers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , peter.maydell@linaro.org, qemu-devel@nongnu.org Cc: mst@redhat.com, jan.kiszka@siemens.com, lcapitulino@redhat.com, blauwirbel@gmail.com, alex.williamson@redhat.com, kraxel@redhat.com, pbonzini@redhat.com Igor Mammedov writes: > global variable qemu_system_powerdown in sysemu.h is the only dep for qemu_irq > and qemu_rise_irq is not a generic way to signal guest that it should shutdown. > > replace it by notifiers and allow each implementation to have it's own way > to notify guest. > > git repo for testing: > https://github.com/imammedo/qemu/tree/shutdown_notifier.v3 > > compile tested: > target-list=x86_64-linux-user,x86_64-softmmu,sparc-softmmu,arm-softmmu > runtime tested: > x86_64-softmmu + win7 guest > > v3-v2: > - fixed bisectably issues of series > - make series independed of cpu_as_device series > Applied. Thanks. Regards, Anthony Liguori > Igor Mammedov (5): > Introduce powerdown_notifiers > acpi: use notifier for signaling guest system_powerdown command > target-arm: use notifier for signaling guest system_powerdown command > target-sparc: use notifier for signaling guest system_powerdown > command > Cleanup unused global var qemu_system_powerdown > > hw/acpi_piix4.c | 8 +++++--- > hw/nseries.c | 14 +++++++++++++- > hw/sun4m.c | 14 +++++++++++++- > sysemu.h | 2 +- > vl.c | 18 ++++++++++++++---- > 5 files changed, 46 insertions(+), 10 deletions(-) > > -- > 1.7.11.4