From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGenH-0001Nk-AU for qemu-devel@nongnu.org; Tue, 25 Sep 2012 19:44:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGenG-0006vH-0v for qemu-devel@nongnu.org; Tue, 25 Sep 2012 19:43:59 -0400 Received: from mail-oa0-f45.google.com ([209.85.219.45]:46051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGenF-0006v0-Sj for qemu-devel@nongnu.org; Tue, 25 Sep 2012 19:43:57 -0400 Received: by oagi18 with SMTP id i18so3767oag.4 for ; Tue, 25 Sep 2012 16:43:57 -0700 (PDT) From: Anthony Liguori In-Reply-To: <1348486090-21177-1-git-send-email-kraxel@redhat.com> References: <1348486090-21177-1-git-send-email-kraxel@redhat.com> Date: Tue, 25 Sep 2012 18:43:53 -0500 Message-ID: <873925sm6e.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 0/2] add pci-serial device. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Gerd Hoffmann writes: > Hi, > > Two patches, first split up serial.c a bit, > then actually add the pci-based serial device. The series looks good to me. A couple requests: 1) Could you add a spec describing this new PCI device? Doesn't need to be more than a couple paragraphs since the device is super simple. 2) Could you make the inf file an separate patch and either include documentation in the commit message on how to use it with Windows or just add a comment to the inf file? This is a new PCI space for QEMU too. Is this a driver that is "owned" by QEMU and Red Hat is donating the PCI id or is this a driver that RH controls that we're implementing? The only reason I ask is whether this is something we can add new features to. I can't think of one off hand, but it can't hurt to work this out up front. Regards, Anthony Liguori > > cheers, > Gerd > > Gerd Hoffmann (2): > serial: split serial.c > serial: add pci variant > > default-configs/pci.mak | 2 + > docs/pciserial.inf | 96 +++++++++++++++++++++++++++++++ > hw/Makefile.objs | 3 +- > hw/alpha_dp264.c | 1 + > hw/kzm.c | 2 +- > hw/mips_fulong2e.c | 1 + > hw/mips_jazz.c | 1 + > hw/mips_malta.c | 1 + > hw/mips_mipssim.c | 2 +- > hw/mips_r4k.c | 1 + > hw/musicpal.c | 2 +- > hw/omap_uart.c | 3 +- > hw/openrisc_sim.c | 3 +- > hw/pc.c | 1 + > hw/pc.h | 27 --------- > hw/pci_ids.h | 1 + > hw/petalogix_ml605_mmu.c | 2 +- > hw/ppc/e500.c | 2 +- > hw/ppc405_uc.c | 2 +- > hw/ppc440_bamboo.c | 2 +- > hw/ppc_prep.c | 1 + > hw/pxa2xx.c | 2 +- > hw/serial-isa.c | 130 +++++++++++++++++++++++++++++++++++++++++ > hw/serial-pci.c | 101 ++++++++++++++++++++++++++++++++ > hw/serial.c | 143 ++-------------------------------------------- > hw/serial.h | 73 +++++++++++++++++++++++ > hw/sm501.c | 2 +- > hw/sun4u.c | 1 + > hw/virtex_ml507.c | 2 +- > hw/xtensa_lx60.c | 3 +- > 30 files changed, 433 insertions(+), 180 deletions(-) > create mode 100644 docs/pciserial.inf > create mode 100644 hw/serial-isa.c > create mode 100644 hw/serial-pci.c > create mode 100644 hw/serial.h