From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4XAm-0000Fq-CF for qemu-devel@nongnu.org; Thu, 23 Aug 2012 09:10:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4XAc-0003WS-6B for qemu-devel@nongnu.org; Thu, 23 Aug 2012 09:10:06 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:50022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4XAc-0003WO-2I for qemu-devel@nongnu.org; Thu, 23 Aug 2012 09:09:58 -0400 Received: from /spool/local by e6.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 23 Aug 2012 09:09:56 -0400 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id B5E926E804D for ; Thu, 23 Aug 2012 09:09:22 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q7ND9MD738273150 for ; Thu, 23 Aug 2012 09:09:22 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q7ND9Lrw024199 for ; Thu, 23 Aug 2012 09:09:21 -0400 From: Anthony Liguori In-Reply-To: <50361C0C.3060503@suse.de> References: <1345667067-24298-1-git-send-email-aliguori@us.ibm.com> <87k3wqo8f6.fsf@codemonkey.ws> <50361C0C.3060503@suse.de> Date: Thu, 23 Aug 2012 08:09:18 -0500 Message-ID: <87393dwy9t.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] boards: add a 'none' machine type to all platforms List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: Peter Maydell , qemu-devel@nongnu.org, Markus Armbruster Andreas F=C3=A4rber writes: > Am 23.08.2012 00:42, schrieb Anthony Liguori: >> Peter Maydell writes: >>=20 >>> On 22 August 2012 21:24, Anthony Liguori wrote: >>> >>> We seem to be about evenly split about whether machine_init() >>> should have a trailing semicolon (it doesn't need one >>> but it doesn't hurt either...) >>=20 >> It's obviously superior to use a semicolon... C is completely >> consistent synactically about the usage of semicolons afterall :-) > > I disagree. This macro does not turn into a statement but a full > function definition. Neither our Coding Style nor any other that I know > does I was only responding to be funny. This is not something worth anyone arguing about. We've got *much* more important things to sort through. Regards, Anthony Liguori > > void foo(bar baz) > { > }; > > with a trailing semicolon. For type_init() I cleaned this up, and I > attribute the existing semicolons to people's ignorance of what these > macros actually do. > > You might remember that Eduardo and I wanted to QOM'ify machines so that > machine_init() would get replaced with type_init() but you stopped us at > the time, leaving it untouched. So there's no strict need to go through > and change existing users, but I believe in setting good examples. > > Regards, > Andreas > > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3= =BCrnberg