From: Anthony Liguori <aliguori@us.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>,
Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols
Date: Mon, 13 Aug 2012 08:44:29 -0500 [thread overview]
Message-ID: <87393qhpoi.fsf@codemonkey.ws> (raw)
In-Reply-To: <CAFEAcA_d9SELeuDf_OAjdZPSgz1_MdpYVYoXE76mMMoWnTyu0A@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 10 August 2012 17:04, Anthony Liguori <aliguori@us.ibm.com> wrote:
>> This lets us provide a default implementation of a symbol which targets can
>> override.
>>
>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>
> I'm sure you'll be thrilled to hear that this doesn't seem to break MacOS
> builds :-)
Thank you for testing it. I neglected to mention that I did a fair bit
of investigation before hand and was able to confirm that all platforms
we care about (Windows, Linux/Unix, OS X) and all compilers we care
about (GCC, LLVM) support weak symbols.
There may be different attribute names across compilers--it wasn't very
clear to me, but they definitely all have the feature in some form.
Regards,
Anthony Liguori
>
> -- PMM
next prev parent reply other threads:[~2012-08-13 13:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 16:04 [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need (v2) Anthony Liguori
2012-08-10 16:04 ` [Qemu-devel] [PATCH 1/7] qmp: introduce device-list-properties command Anthony Liguori
2012-08-10 16:04 ` [Qemu-devel] [PATCH 2/7] qapi: mark QOM commands stable Anthony Liguori
2012-08-10 18:20 ` Eric Blake
2012-08-10 18:27 ` Anthony Liguori
2012-08-10 16:04 ` [Qemu-devel] [PATCH 3/7] qapi: add query-machines command Anthony Liguori
2012-08-10 16:04 ` [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols Anthony Liguori
2012-08-12 21:30 ` Peter Maydell
2012-08-13 13:44 ` Anthony Liguori [this message]
2012-08-10 16:04 ` [Qemu-devel] [PATCH 5/7] qapi: add query-cpu-definitions command (v2) Anthony Liguori
2012-08-10 16:04 ` [Qemu-devel] [PATCH 6/7] target-i386: add implementation of query-cpu-definitions (v2) Anthony Liguori
2012-08-10 16:04 ` [Qemu-devel] [PATCH 7/7] target-ppc: " Anthony Liguori
2012-08-13 17:16 ` [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need (v2) Luiz Capitulino
2012-08-13 19:18 ` Luiz Capitulino
2012-08-13 19:37 ` Anthony Liguori
2012-08-15 6:07 ` Stefan Weil
2012-08-15 16:53 ` Luiz Capitulino
2012-08-16 11:58 ` Stefan Weil
-- strict thread matches above, loose matches on Subject: below --
2012-07-27 13:37 [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need to parse -help output Anthony Liguori
2012-07-27 13:37 ` [Qemu-devel] [PATCH 4/7] compiler: add macro for GCC weak symbols Anthony Liguori
2012-07-27 13:50 ` Peter Maydell
2012-07-27 14:27 ` Anthony Liguori
2012-07-27 14:45 ` Peter Maydell
2012-07-27 15:31 ` Anthony Liguori
2012-07-27 19:34 ` Blue Swirl
2012-07-27 20:51 ` Anthony Liguori
2012-07-27 21:04 ` Blue Swirl
2012-07-27 22:40 ` Anthony Liguori
2012-07-28 6:25 ` Markus Armbruster
2012-07-28 8:52 ` Blue Swirl
2012-07-28 8:45 ` Blue Swirl
2012-07-28 6:50 ` Peter Maydell
2012-07-28 8:58 ` Blue Swirl
2012-07-27 15:32 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87393qhpoi.fsf@codemonkey.ws \
--to=aliguori@us.ibm.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).