From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuWqF-00010n-P0 for qemu-devel@nongnu.org; Thu, 26 Jul 2012 18:47:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SuWqE-0006WS-I3 for qemu-devel@nongnu.org; Thu, 26 Jul 2012 18:47:35 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:34471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SuWqE-0006WI-BO for qemu-devel@nongnu.org; Thu, 26 Jul 2012 18:47:34 -0400 Received: by pbbro12 with SMTP id ro12so3790905pbb.4 for ; Thu, 26 Jul 2012 15:47:33 -0700 (PDT) From: Anthony Liguori In-Reply-To: <20120726181408.5e63efe1@doriath.home> References: <87ipdacrhj.fsf@codemonkey.ws> <20120726154358.69eee026@doriath.home> <20120726154711.30784ba5@doriath.home> <87394e1b89.fsf@codemonkey.ws> <20120726181408.5e63efe1@doriath.home> Date: Thu, 26 Jul 2012 17:47:25 -0500 Message-ID: <87394e9m2q.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] Plan for error handling in QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Kevin Wolf , Paolo Bonzini , qemu-devel@nongnu.org, Markus Armbruster Luiz Capitulino writes: > On Thu, 26 Jul 2012 16:08:54 -0500 > Anthony Liguori wrote: > >> Luiz Capitulino writes: >> >> > On Thu, 26 Jul 2012 15:43:58 -0300 >> > Luiz Capitulino wrote: >> > >> >> On Thu, 26 Jul 2012 13:22:15 -0500 >> >> anthony@codemonkey.ws wrote: >> >> >> >> > >> >> > Hi, >> >> > >> >> > We had a violent^Wheated discussion on IRC about how to move forward >> >> > with Luiz's proposed error series. I think we reached consensus. This >> >> > note attempts to outline that. >> >> >> >> This looks great to me, violent^W heated discussions can be so productive :) >> >> >> >> > >> >> > Principles >> >> > ---------- >> >> > 1. Errors should be free formed strings with a class code >> >> > >> >> > 2. There should be a small number of class codes (10-15) added >> >> > strictly when there are specific users of a code. >> > >> > Btw, do we have a listing of those 10-15 errors already? >> >> See the clause: "added strictly when there are specific users". >> >> Users means consumers. So don't add an error type until someone cares >> to differientiate error reasons. > > What I meant is that, for 1.2 we want to reduce from 71 error codes to 10-15, > right? If that's right what are the 10-15 errors that won't be dropped? > > Or did I misunderstand? I meant drop it down to 5-6. The existing errors that libvirt cares about plus an UnknownError. #define all existing error codes to UnknownError and then at our leisure, we can introduce more generic classes and refactor errors incrementally. Regards, Anthony Liguori