From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60610)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1ScTfC-0005ad-RR
	for qemu-devel@nongnu.org; Wed, 06 Jun 2012 23:45:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1ScTfB-0002RF-2J
	for qemu-devel@nongnu.org; Wed, 06 Jun 2012 23:45:34 -0400
Received: from e23smtp05.au.ibm.com ([202.81.31.147]:60602)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1ScTf6-0002Qs-O0
	for qemu-devel@nongnu.org; Wed, 06 Jun 2012 23:45:32 -0400
Received: from /spool/local
	by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aneesh.kumar@linux.vnet.ibm.com>;
	Thu, 7 Jun 2012 03:39:48 +1000
Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138])
	by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q573c1we62521414
	for <qemu-devel@nongnu.org>; Thu, 7 Jun 2012 13:38:01 +1000
Received: from d23av02.au.ibm.com (loopback [127.0.0.1])
	by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	q573jDlP016217
	for <qemu-devel@nongnu.org>; Thu, 7 Jun 2012 13:45:13 +1000
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
In-Reply-To: <4FCF855D.8050208@weilnetz.de>
References: <20120224195143.GA16353@vostro.hallyn.com>
	<alpine.DEB.2.02.1206061135350.6030@kaball.uk.xensource.com>
	<4FCF855D.8050208@weilnetz.de>User-Agent:
	Notmuch/0.11.1+346~g13d19c3 (http://notmuchmail.org)
	Emacs/23.3.1 (x86_64-pc-linux-gnu)
Date: Thu, 07 Jun 2012 09:15:07 +0530
Message-ID: <873967oke4.fsf@skywalker.in.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [BUG QEMU 1.1] virtio-9p-handle does not compile
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>, Serge Hallyn <serge.hallyn@canonical.com>
Cc: "aliguori@us.ibm.com" <aliguori@us.ibm.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Stefan Weil <sw@weilnetz.de> writes:

> Am 06.06.2012 12:50, schrieb Stefano Stabellini:
>> Hi Anthony,
>> currently QEMU 1.1 doesn't compile virtfs correctly on Ubuntu:
>>
.....

>
> The patch will fix the compiler error messages, but will the
> resulting code work? Maybe it has runtime dependencies
> (Linux kernel?) which should be checked at runtime.
>
> Would an enhanced test in configure be a better solution?
> It could disable VirtFS automatically if the definitions
> are missing.
>
> On Ubuntu Lenny, there is no definition for AT_EMPTY_PATH,
> not even in linux/fcntl.h.

We enable virtio-9p-handle only if open_by_handle_at is supported by
glibc. And if open_by_handle_at is supported by glibc AT_EMPTY_PATH
should also be there, because they all went in linux kernel for the same
feature set. So if glibc didn't pick AT_EMPTY_PATH definition and
took open_by_handle_at feature, it should be fixed in glibc.

BTW I am still not clear why including linux/fcntl.h gives those
compile errors. IMHO fixing those errors and including linux/fcntl.h in
virtio-9p-handle.c would be a better fix than redefining these constants.

-aneesh