From: Markus Armbruster <armbru@redhat.com>
To: Shameer Kolothum Thodi <skolothumtho@nvidia.com>
Cc: "Nathan Chen" <nathanc@nvidia.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"Eric Auger" <eric.auger@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Ani Sinha" <anisinha@redhat.com>,
"Shannon Zhao" <shannon.zhaosl@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P.Berrangé" <berrange@redhat.com>,
"Eric Blake" <eblake@redhat.com>, "Matt Ochs" <mochs@nvidia.com>,
"Nicolin Chen" <nicolinc@nvidia.com>
Subject: Re: [PATCH v4 5/8] hw/arm/smmuv3-accel: Change SSIDSIZE property to SsidSizeMode
Date: Tue, 24 Mar 2026 06:39:37 +0100 [thread overview]
Message-ID: <874im5wzty.fsf@pond.sub.org> (raw)
In-Reply-To: <CH3PR12MB7548E042617EA0BDFB34C55BAB4BA@CH3PR12MB7548.namprd12.prod.outlook.com> (Shameer Kolothum Thodi's message of "Mon, 23 Mar 2026 17:41:29 +0000")
Shameer Kolothum Thodi <skolothumtho@nvidia.com> writes:
>> On 3/19/2026 5:14 AM, Markus Armbruster wrote:
[...]
>> > Any particular reason this is called @ssidsize and not @ssid-size?
>>
>> I'm not sure there's a particular reason - this property was newly
>> introduced in the accel SMMUv3 series [0]. Should we include a patch to
>> change it to @ssid-size to match the format of other properties?
Separating words improves legibility. docs/devel/qapi-code-gen.rst
section "Naming rules and reserved names":
Command names, member names within a type, and feature names should
be all lower case with words separated by a hyphen.
However, we have a compelling reason for @ssidsize:
> I don't think we should as that name was selected to match the SMMUv3
> IDR1 register filed name in the SMMUv3 specification.
Thanks!
next prev parent reply other threads:[~2026-03-24 5:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 18:48 [PATCH for-11.0 v4 0/8] hw/arm/smmuv3-accel: Support AUTO properties Nathan Chen
2026-03-18 18:49 ` [PATCH v4 1/8] hw/arm/smmuv3-accel: Check ATS compatibility between host and guest Nathan Chen
2026-03-18 18:49 ` [PATCH v4 2/8] hw/arm/smmuv3-accel: Change ATS property to OnOffAuto Nathan Chen
2026-03-19 8:10 ` Shameer Kolothum Thodi
2026-03-19 9:35 ` Eric Auger
2026-03-19 11:54 ` Markus Armbruster
2026-03-18 18:49 ` [PATCH v4 3/8] hw/arm/smmuv3-accel: Change RIL " Nathan Chen
2026-03-19 8:12 ` Shameer Kolothum Thodi
2026-03-19 9:37 ` Eric Auger
2026-03-19 11:55 ` Markus Armbruster
2026-03-18 18:49 ` [PATCH v4 4/8] qdev: Add a SsidSizeMode property Nathan Chen
2026-03-19 12:02 ` Markus Armbruster
2026-03-19 12:08 ` Markus Armbruster
2026-03-18 18:49 ` [PATCH v4 5/8] hw/arm/smmuv3-accel: Change SSIDSIZE property to SsidSizeMode Nathan Chen
2026-03-19 8:35 ` Shameer Kolothum Thodi
2026-03-19 9:48 ` Eric Auger
2026-03-19 12:14 ` Markus Armbruster
2026-03-23 17:28 ` Nathan Chen
2026-03-23 17:41 ` Shameer Kolothum Thodi
2026-03-24 5:39 ` Markus Armbruster [this message]
2026-03-23 17:41 ` Eric Auger
2026-03-18 18:49 ` [PATCH v4 6/8] qdev: Add an OasMode property Nathan Chen
2026-03-19 12:16 ` Markus Armbruster
2026-03-18 18:49 ` [PATCH v4 7/8] hw/arm/smmuv3-accel: Change OAS property to OasMode Nathan Chen
2026-03-19 8:39 ` Shameer Kolothum Thodi
2026-03-19 9:51 ` Eric Auger
2026-03-19 12:20 ` Markus Armbruster
2026-03-19 16:57 ` Nathan Chen
2026-03-20 7:53 ` Markus Armbruster
2026-03-23 17:47 ` Nathan Chen
2026-03-18 18:49 ` [PATCH v4 8/8] qemu-options.hx: Document arm-smmuv3 device's accel properties Nathan Chen
2026-03-19 12:21 ` Markus Armbruster
2026-03-19 17:07 ` Nathan Chen
2026-03-19 10:01 ` [PATCH for-11.0 v4 0/8] hw/arm/smmuv3-accel: Support AUTO properties Eric Auger
2026-03-19 10:15 ` Shameer Kolothum Thodi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874im5wzty.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=anisinha@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eric.auger@redhat.com \
--cc=imammedo@redhat.com \
--cc=mochs@nvidia.com \
--cc=mst@redhat.com \
--cc=nathanc@nvidia.com \
--cc=nicolinc@nvidia.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=skolothumtho@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox