* [PATCH] contrib/plugins/uftrace_symbols.py: unbreak --no-prefix-symbols
@ 2025-12-05 10:56 Sönke Holz
2025-12-05 14:02 ` Pierrick Bouvier
2025-12-05 15:18 ` Alex Bennée
0 siblings, 2 replies; 4+ messages in thread
From: Sönke Holz @ 2025-12-05 10:56 UTC (permalink / raw)
To: qemu-devel
Cc: Sönke Holz, Alex Bennée, Alexandre Iooss,
Mahmoud Mandour, Pierrick Bouvier
Since 8a545a336d, `name` is unbound if --no-prefix-symbols is passed,
causing this script to break when that option is set.
Signed-off-by: Sönke Holz <sholz8530@gmail.com>
---
contrib/plugins/uftrace_symbols.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/contrib/plugins/uftrace_symbols.py b/contrib/plugins/uftrace_symbols.py
index 45fb79c7a5..21704541a6 100755
--- a/contrib/plugins/uftrace_symbols.py
+++ b/contrib/plugins/uftrace_symbols.py
@@ -98,6 +98,8 @@ def generate_symbol_file(self, prefix_symbols):
size = f'{s.size:{addrx}}'
if prefix_symbols:
name = f'{binary_name}:{s.name}'
+ else:
+ name = s.name
print(addr, size, 'T', name, file=sym_file)
def generate_debug_file(self):
--
2.52.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] contrib/plugins/uftrace_symbols.py: unbreak --no-prefix-symbols
2025-12-05 10:56 [PATCH] contrib/plugins/uftrace_symbols.py: unbreak --no-prefix-symbols Sönke Holz
@ 2025-12-05 14:02 ` Pierrick Bouvier
2025-12-05 14:03 ` Pierrick Bouvier
2025-12-05 15:18 ` Alex Bennée
1 sibling, 1 reply; 4+ messages in thread
From: Pierrick Bouvier @ 2025-12-05 14:02 UTC (permalink / raw)
To: Sönke Holz, qemu-devel
Cc: Alex Bennée, Alexandre Iooss, Mahmoud Mandour
On 12/5/25 2:56 AM, Sönke Holz wrote:
> Since 8a545a336d, `name` is unbound if --no-prefix-symbols is passed,
> causing this script to break when that option is set.
>
> Signed-off-by: Sönke Holz <sholz8530@gmail.com>
> ---
> contrib/plugins/uftrace_symbols.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/contrib/plugins/uftrace_symbols.py b/contrib/plugins/uftrace_symbols.py
> index 45fb79c7a5..21704541a6 100755
> --- a/contrib/plugins/uftrace_symbols.py
> +++ b/contrib/plugins/uftrace_symbols.py
> @@ -98,6 +98,8 @@ def generate_symbol_file(self, prefix_symbols):
> size = f'{s.size:{addrx}}'
> if prefix_symbols:
> name = f'{binary_name}:{s.name}'
> + else:
> + name = s.name
> print(addr, size, 'T', name, file=sym_file)
>
> def generate_debug_file(self):
Thanks for catching it, I was indeed always using this option for testing.
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] contrib/plugins/uftrace_symbols.py: unbreak --no-prefix-symbols
2025-12-05 14:02 ` Pierrick Bouvier
@ 2025-12-05 14:03 ` Pierrick Bouvier
0 siblings, 0 replies; 4+ messages in thread
From: Pierrick Bouvier @ 2025-12-05 14:03 UTC (permalink / raw)
To: Sönke Holz, qemu-devel
Cc: Alex Bennée, Alexandre Iooss, Mahmoud Mandour
On 12/5/25 6:02 AM, Pierrick Bouvier wrote:
> On 12/5/25 2:56 AM, Sönke Holz wrote:
>> Since 8a545a336d, `name` is unbound if --no-prefix-symbols is passed,
>> causing this script to break when that option is set.
>>
>> Signed-off-by: Sönke Holz <sholz8530@gmail.com>
>> ---
>> contrib/plugins/uftrace_symbols.py | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/contrib/plugins/uftrace_symbols.py b/contrib/plugins/uftrace_symbols.py
>> index 45fb79c7a5..21704541a6 100755
>> --- a/contrib/plugins/uftrace_symbols.py
>> +++ b/contrib/plugins/uftrace_symbols.py
>> @@ -98,6 +98,8 @@ def generate_symbol_file(self, prefix_symbols):
>> size = f'{s.size:{addrx}}'
>> if prefix_symbols:
>> name = f'{binary_name}:{s.name}'
>> + else:
>> + name = s.name
>> print(addr, size, 'T', name, file=sym_file)
>>
>> def generate_debug_file(self):
>
> Thanks for catching it, I was indeed always using this option for testing.
> Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>
@alex.bennée, any chance it can be integrated for release, when you will
pull Final fixes for 10.2?
Thanks,
Pierrick
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] contrib/plugins/uftrace_symbols.py: unbreak --no-prefix-symbols
2025-12-05 10:56 [PATCH] contrib/plugins/uftrace_symbols.py: unbreak --no-prefix-symbols Sönke Holz
2025-12-05 14:02 ` Pierrick Bouvier
@ 2025-12-05 15:18 ` Alex Bennée
1 sibling, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2025-12-05 15:18 UTC (permalink / raw)
To: Sönke Holz
Cc: qemu-devel, Alexandre Iooss, Mahmoud Mandour, Pierrick Bouvier
Sönke Holz <sholz8530@gmail.com> writes:
> Since 8a545a336d, `name` is unbound if --no-prefix-symbols is passed,
> causing this script to break when that option is set.
>
> Signed-off-by: Sönke Holz <sholz8530@gmail.com>
Queued to pr/051225-10.2-final-fixes-1, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-12-05 15:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-05 10:56 [PATCH] contrib/plugins/uftrace_symbols.py: unbreak --no-prefix-symbols Sönke Holz
2025-12-05 14:02 ` Pierrick Bouvier
2025-12-05 14:03 ` Pierrick Bouvier
2025-12-05 15:18 ` Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).