From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BDA3CAC5B5 for ; Mon, 29 Sep 2025 14:49:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3FAh-0000FV-VY; Mon, 29 Sep 2025 10:48:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3FAa-0000Dp-NP for qemu-devel@nongnu.org; Mon, 29 Sep 2025 10:48:05 -0400 Received: from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v3FAR-0003Yr-Vl for qemu-devel@nongnu.org; Mon, 29 Sep 2025 10:48:03 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 918AF20636; Mon, 29 Sep 2025 14:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1759157266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uRUfvGswh1OJug3yHJbu1FVYq4Qh3D52KuYemEk+S+8=; b=rllJOn4brIasrnyWCRvaC5iapmBuymIrMJ3KG/ZJ5/ti55DARSRjxB451oegvTrwmJjMMs zMfuocDcaMjoCMCLsoOxllhz4Boow1DGM7Du2C+kCZqzjkTxrAIQ/FfxyuNAfnNfLyppiA CQnoER2uC8PpZGY0fnG1jTCkqiiyYQc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1759157266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uRUfvGswh1OJug3yHJbu1FVYq4Qh3D52KuYemEk+S+8=; b=e7+QpQoDWLaqrGzq5HjELp/r+xBCkMyY7JOca9nlqF7JAX4f0a5+CQG8y06TEDyl55fVgs 7DszCDcjFaWqD8Ag== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=rllJOn4b; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=e7+QpQoD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1759157266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uRUfvGswh1OJug3yHJbu1FVYq4Qh3D52KuYemEk+S+8=; b=rllJOn4brIasrnyWCRvaC5iapmBuymIrMJ3KG/ZJ5/ti55DARSRjxB451oegvTrwmJjMMs zMfuocDcaMjoCMCLsoOxllhz4Boow1DGM7Du2C+kCZqzjkTxrAIQ/FfxyuNAfnNfLyppiA CQnoER2uC8PpZGY0fnG1jTCkqiiyYQc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1759157266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uRUfvGswh1OJug3yHJbu1FVYq4Qh3D52KuYemEk+S+8=; b=e7+QpQoDWLaqrGzq5HjELp/r+xBCkMyY7JOca9nlqF7JAX4f0a5+CQG8y06TEDyl55fVgs 7DszCDcjFaWqD8Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 079C013782; Mon, 29 Sep 2025 14:47:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id DT9uLRGc2mh5NwAAD6G6ig (envelope-from ); Mon, 29 Sep 2025 14:47:45 +0000 From: Fabiano Rosas To: Steve Sistare , qemu-devel@nongnu.org Cc: Laurent Vivier , Paolo Bonzini , Peter Xu , Steve Sistare Subject: Re: [PATCH V1 01/11] tests/qtest: export qtest_qemu_binary In-Reply-To: <1758291153-349744-2-git-send-email-steven.sistare@oracle.com> References: <1758291153-349744-1-git-send-email-steven.sistare@oracle.com> <1758291153-349744-2-git-send-email-steven.sistare@oracle.com> Date: Mon, 29 Sep 2025 11:47:43 -0300 Message-ID: <874islwc1c.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 918AF20636 X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_FIVE(0.00)[6]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:2; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Steve Sistare writes: > Signed-off-by: Steve Sistare > --- > tests/qtest/libqtest.h | 9 +++++++++ > tests/qtest/libqtest.c | 2 +- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/tests/qtest/libqtest.h b/tests/qtest/libqtest.h > index b3f2e7f..6d3199f 100644 > --- a/tests/qtest/libqtest.h > +++ b/tests/qtest/libqtest.h > @@ -48,6 +48,15 @@ QTestState *qtest_initf(const char *fmt, ...) G_GNUC_PRINTF(1, 2); > QTestState *qtest_vinitf(const char *fmt, va_list ap) G_GNUC_PRINTF(1, 0); > > /** > + * qtest_qemu_binary: > + * @var: environment variable name > + * > + * Look up @var and return its value as the qemu binary path. > + * If @var is NULL, look up the default var name. > + */ > +const char *qtest_qemu_binary(const char *var); > + > +/** > * qtest_init: > * @extra_args: other arguments to pass to QEMU. CAUTION: these > * arguments are subject to word splitting and shell evaluation. > diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c > index f3d4e08..6f76be1 100644 > --- a/tests/qtest/libqtest.c > +++ b/tests/qtest/libqtest.c > @@ -357,7 +357,7 @@ void qtest_remove_abrt_handler(void *data) > } > } > > -static const char *qtest_qemu_binary(const char *var) > +const char *qtest_qemu_binary(const char *var) > { > const char *qemu_bin; Reviewed-by: Fabiano Rosas