From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A8C5CAC59A for ; Fri, 19 Sep 2025 12:29:02 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uzaDN-0008Gt-J7; Fri, 19 Sep 2025 08:27:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uzaDD-0008G5-9T for qemu-devel@nongnu.org; Fri, 19 Sep 2025 08:27:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uzaD7-00055s-7w for qemu-devel@nongnu.org; Fri, 19 Sep 2025 08:27:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758284849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gkZuhX84S42dAzWd5lDeM01IGWlt01IQDxVV7y6SdAg=; b=EVJ+tOIimRLnxEL8J0dpdWHp7Gxz7SK1A9Rc/DpQzsFbQPXbFFrcy0Awf9xjyv86fpd2RX fiscJx7lnkczuy+83SBg4qfJ4I+6/aQEe87nzYVL/2THw/Pm4tGT+DNPBHD9JQllbzOCgK 5RZOP/iwhV3e6O4S4nF0a1DIRtOIjmI= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-UAhuhii-PpqGouTZ893T3Q-1; Fri, 19 Sep 2025 08:27:25 -0400 X-MC-Unique: UAhuhii-PpqGouTZ893T3Q-1 X-Mimecast-MFC-AGG-ID: UAhuhii-PpqGouTZ893T3Q_1758284844 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D0EC5180034D; Fri, 19 Sep 2025 12:27:23 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.33]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 49E9E1800447; Fri, 19 Sep 2025 12:27:23 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 93F5721E6A27; Fri, 19 Sep 2025 14:27:20 +0200 (CEST) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Hanna Reitz , Kevin Wolf , =?utf-8?Q?Marc-Andr?= =?utf-8?Q?=C3=A9?= Lureau , Christian Schoenebeck , Richard Henderson , Manos Pitsidianakis , Stefan Weil , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Gerd Hoffmann , Paolo Bonzini , "Dr. David Alan Gilbert" Subject: Re: [PATCH v3 11/20] monitor: move error_vprintf() back to error-report.c In-Reply-To: <20250910180357.320297-12-berrange@redhat.com> ("Daniel P. =?utf-8?Q?Berrang=C3=A9=22's?= message of "Wed, 10 Sep 2025 19:03:48 +0100") References: <20250910180357.320297-1-berrange@redhat.com> <20250910180357.320297-12-berrange@redhat.com> Date: Fri, 19 Sep 2025 14:27:20 +0200 Message-ID: <874isyy6dz.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.105, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > This conceptually reverts 397d30e9401d2da96dbdf0ce49805d6d4bb68833. > The discussion around stubs in that commit does not appear to be > important to the current state of the codebase. Can we figure out why Paolo's change is no longer needed? Discussion back then: https://lore.kernel.org/qemu-devel/37942764-b3c8-1ac1-5121-894ada7300f2@red= hat.com/ https://lore.kernel.org/qemu-devel/1477326663-67817-1-git-send-email-pbonzi= ni@redhat.com/ > This makes the error_vprintf() impl source file match that > of error_printf(), and also match the header where it is declared. > > Signed-off-by: Daniel P. Berrang=C3=A9