From: Cornelia Huck <cohuck@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org,
kvmarm@lists.linux.dev
Subject: Re: [PATCH 15/15] arm/cpu: Add generated files
Date: Mon, 10 Feb 2025 16:20:28 +0100 [thread overview]
Message-ID: <874j117rnn.fsf@redhat.com> (raw)
In-Reply-To: <f5878231-79b8-4e29-bfb0-f9a57ac3f6a4@linaro.org>
On Fri, Feb 07 2025, Richard Henderson <richard.henderson@linaro.org> wrote:
> On 2/7/25 03:02, Cornelia Huck wrote:
>> And switch to using the generated definitions.
>>
>> Generated against Linux 6.14-rc1.
>>
>> Signed-off-by: Cornelia Huck<cohuck@redhat.com>
>> ---
>> target/arm/cpu-sysreg-properties.c | 716 ++++++++++++++++++++++++++++-
>> target/arm/cpu-sysregs.h | 116 +----
>> target/arm/cpu-sysregs.h.inc | 164 +++++++
>> 3 files changed, 860 insertions(+), 136 deletions(-)
>> create mode 100644 target/arm/cpu-sysregs.h.inc
>
> Why are we committing generated files and not generating them at build-time?
We'd either have to carry a copy of Linux' sysregs file, or generate a
build dependency on Linux. I think we should handle this similar to the
Linux headers update, where we do an explicit update and check for
anything unexpected that might have crept in. (Same applies if we switch
to any other external source for register definitions.)
next prev parent reply other threads:[~2025-02-10 15:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 11:02 [PATCH 00/15] arm: rework id register storage Cornelia Huck
2025-02-07 11:02 ` [PATCH 01/15] arm/cpu: Add sysreg definitions in cpu-sysregs.h Cornelia Huck
2025-02-07 18:34 ` Richard Henderson
2025-02-18 15:22 ` Eric Auger
2025-02-07 11:02 ` [PATCH 02/15] arm/kvm: add accessors for storing host features into idregs Cornelia Huck
2025-02-07 18:43 ` Richard Henderson
2025-02-07 18:50 ` Richard Henderson
2025-02-18 15:33 ` Eric Auger
2025-02-18 15:54 ` Cornelia Huck
2025-02-07 11:02 ` [PATCH 03/15] arm/cpu: Store aa64isar0 into the idregs arrays Cornelia Huck
2025-02-07 18:46 ` Richard Henderson
2025-02-18 15:53 ` Eric Auger
2025-02-07 11:02 ` [PATCH 04/15] arm/cpu: Store aa64isar1/2 into the idregs array Cornelia Huck
2025-02-07 11:02 ` [PATCH 05/15] arm/cpu: Store aa64pfr0/1 " Cornelia Huck
2025-02-07 11:02 ` [PATCH 06/15] arm/cpu: Store aa64mmfr0-3 " Cornelia Huck
2025-02-07 11:02 ` [PATCH 07/15] arm/cpu: Store aa64dfr0/1 " Cornelia Huck
2025-02-07 11:02 ` [PATCH 08/15] arm/cpu: Store aa64smfr0 " Cornelia Huck
2025-02-07 11:02 ` [PATCH 09/15] arm/cpu: Store id_isar0-7 " Cornelia Huck
2025-02-07 11:02 ` [PATCH 10/15] arm/cpu: Store id_mfr0/1 " Cornelia Huck
2025-02-07 11:02 ` [PATCH 11/15] arm/cpu: Store id_dfr0/1 " Cornelia Huck
2025-02-07 11:02 ` [PATCH 12/15] arm/cpu: Store id_mmfr0-5 " Cornelia Huck
2025-02-07 11:02 ` [PATCH 13/15] arm/cpu: Add infra to handle generated ID register definitions Cornelia Huck
2025-02-18 16:06 ` Eric Auger
2025-02-07 11:02 ` [PATCH 14/15] arm/cpu: Add sysreg generation scripts Cornelia Huck
2025-02-07 14:14 ` Marc Zyngier
2025-02-07 11:02 ` [PATCH 15/15] arm/cpu: Add generated files Cornelia Huck
2025-02-07 19:02 ` Richard Henderson
2025-02-10 15:20 ` Cornelia Huck [this message]
2025-02-18 15:38 ` Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j117rnn.fsf@redhat.com \
--to=cohuck@redhat.com \
--cc=kvmarm@lists.linux.dev \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).