From: Fabiano Rosas <farosas@suse.de>
To: peterx@redhat.com, qemu-devel@nongnu.org
Cc: "Avihai Horon" <avihaih@nvidia.com>,
peterx@redhat.com, "Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH 1/2] migration/multifd: Cleanup TLS iochannel referencing
Date: Thu, 08 Feb 2024 09:44:53 -0300 [thread overview]
Message-ID: <874jejcegq.fsf@suse.de> (raw)
In-Reply-To: <20240208035126.370620-2-peterx@redhat.com>
peterx@redhat.com writes:
> From: Peter Xu <peterx@redhat.com>
>
> Commit a1af605bd5 ("migration/multifd: fix hangup with TLS-Multifd due to
> blocking handshake") introduced a thread for TLS channels, which will
> resolve the issue on blocking the main thread. However in the same commit
> p->c is slightly abused just to be able to pass over the pointer "p" into
> the thread.
>
> That's the major reason we'll need to conditionally free the io channel in
> the fault paths.
>
> To clean it up, using a separate structure to pass over both "p" and "tioc"
> in the tls handshake thread. Then we can make it a rule that p->c will
> never be set until the channel is completely setup. With that, we can drop
> the tricky conditional unref of the io channel in the error path.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Ok, I'm convinced after reading your reply on the other thread.
Reviewed-by: Fabiano Rosas <farosas@suse.de>
next prev parent reply other threads:[~2024-02-08 12:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 3:51 [PATCH 0/2] migration: cleanup TLS channel referencing peterx
2024-02-08 3:51 ` [PATCH 1/2] migration/multifd: Cleanup TLS iochannel referencing peterx
2024-02-08 12:44 ` Fabiano Rosas [this message]
2024-02-08 14:10 ` Avihai Horon
2024-02-21 3:21 ` Peter Xu
2024-02-08 3:51 ` [PATCH 2/2] migration/multifd: Drop registered_yank peterx
2024-02-08 12:48 ` Fabiano Rosas
2024-02-21 3:20 ` Peter Xu
2024-02-21 12:58 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jejcegq.fsf@suse.de \
--to=farosas@suse.de \
--cc=avihaih@nvidia.com \
--cc=berrange@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).