From: "Alex Bennée" <alex.bennee@linaro.org>
To: Titus Rwantare <titusr@google.com>
Cc: qemu-arm@nongnu.org, minyard@acm.org, philmd@linaro.org,
qemu-devel@nongnu.org
Subject: Re: [PATCH v3 0/8] PMBus fixes and new functions
Date: Mon, 23 Oct 2023 20:10:47 +0100 [thread overview]
Message-ID: <874jih40a3.fsf@linaro.org> (raw)
In-Reply-To: <20231023180837.91785-1-titusr@google.com>
Titus Rwantare <titusr@google.com> writes:
> This patch series contains fixes and improvements to PMBus support in QEMU.
>
> The following has been added:
> - Support for block receive
> - Support for devices with fans
> - Support for the VCAP register for devices with onboard energy storage
> - A bitfield struct for the vout mode register, whose bits determine the formatting of several read commands in PMBus
> Fixes:
> - String read now handles now logs an error when passed an empty string
>
> This series is in preparation for some additional sensors that exercise
> this functionality that will be incoming shortly.
You seem to have missed a number of tags from previous postings:
https://qemu.readthedocs.io/en/master/devel/submitting-a-patch.html#proper-use-of-reviewed-by-tags-can-aid-review
(although I notice we only mention Reviewed-by in the docs)
You can use a tool like b4 to apply a series and collect the tags. It
will also collect the Message-Id's which are also useful.
Once you've fixed up your tags I think as the maintainer you can submit
a pull request.
>
> Thanks
>
> Changes in v3:
> - Added fixes to PMBus: page resets and fault clearing
>
> Changes in v2:
> - Expanded commit descriptions
> - Added the ADM1266 device model that uses new functions
>
> Titus Rwantare (8):
> hw/i2c: pmbus add support for block receive
> hw/i2c: pmbus: add vout mode bitfields
> hw/i2c: pmbus: add fan support
> hw/i2c: pmbus: add VCAP register
> hw/sensor: add ADM1266 device model
> tests/qtest: add tests for ADM1266
> hw/i2c: pmbus: immediately clear faults on request
> hw/i2c: pmbus: reset page register for out of range reads
>
> hw/arm/Kconfig | 1 +
> hw/i2c/pmbus_device.c | 237 +++++++++++++++++++++++++++++--
> hw/sensor/Kconfig | 5 +
> hw/sensor/adm1266.c | 254 ++++++++++++++++++++++++++++++++++
> hw/sensor/meson.build | 1 +
> include/hw/i2c/pmbus_device.h | 17 +++
> tests/qtest/adm1266-test.c | 123 ++++++++++++++++
> tests/qtest/max34451-test.c | 24 ++++
> tests/qtest/meson.build | 1 +
> 9 files changed, 653 insertions(+), 10 deletions(-)
> create mode 100644 hw/sensor/adm1266.c
> create mode 100644 tests/qtest/adm1266-test.c
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-10-23 19:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 18:08 [PATCH v3 0/8] PMBus fixes and new functions Titus Rwantare
2023-10-23 18:08 ` [PATCH v3 1/8] hw/i2c: pmbus add support for block receive Titus Rwantare
2023-10-23 18:08 ` [PATCH v3 2/8] hw/i2c: pmbus: add vout mode bitfields Titus Rwantare
2023-10-23 18:08 ` [PATCH v3 3/8] hw/i2c: pmbus: add fan support Titus Rwantare
2023-10-23 18:08 ` [PATCH v3 4/8] hw/i2c: pmbus: add VCAP register Titus Rwantare
2023-10-23 18:08 ` [PATCH v3 5/8] hw/sensor: add ADM1266 device model Titus Rwantare
2023-10-23 18:08 ` [PATCH v3 6/8] tests/qtest: add tests for ADM1266 Titus Rwantare
2023-10-23 18:08 ` [PATCH v3 7/8] hw/i2c: pmbus: immediately clear faults on request Titus Rwantare
2023-10-23 18:08 ` [PATCH v3 8/8] hw/i2c: pmbus: reset page register for out of range reads Titus Rwantare
2023-10-23 19:10 ` Alex Bennée [this message]
2023-10-23 23:53 ` [PATCH v3 0/8] PMBus fixes and new functions Titus Rwantare
2023-10-24 10:06 ` Alex Bennée
2023-10-24 11:50 ` Philippe Mathieu-Daudé
2023-10-24 16:07 ` Titus Rwantare
2023-10-25 5:56 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jih40a3.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=minyard@acm.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=titusr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).