Re: [PATCH v4 01/11] reset: allow registering handlers that aren't called by snapshot loading

[Markus Armbruster <armbru@redhat.com>]

"Jason A. Donenfeld" <Jason@zx2c4.com> writes:

> Snapshot loading only expects to call deterministic handlers, not
> non-deterministic ones. So introduce a way of registering handlers that
> won't be called when reseting for snapshots.
>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

[...]

> diff --git a/qapi/run-state.json b/qapi/run-state.json
> index 49989d30e6..e44c0de914 100644
> --- a/qapi/run-state.json
> +++ b/qapi/run-state.json
> @@ -86,12 +86,15 @@
>  #                   ignores --no-reboot. This is useful for sanitizing
>  #                   hypercalls on s390 that are used during kexec/kdump/boot
>  #
> +# @snapshot-load: A snapshot is being loaded by the record & replay
> +#                 subsystem; internal value (since 7.2)
> +#

If "internal value" was an established way to mark parts that aren't
visible externally, this would do.  Since it isn't, it's too terse.
Suggest something like "This value is used only within QEMU.  It doesn't
occur in QMP."

>  ##
>  { 'enum': 'ShutdownCause',
>    # Beware, shutdown_caused_by_guest() depends on enumeration order
>    'data': [ 'none', 'host-error', 'host-qmp-quit', 'host-qmp-system-reset',
>              'host-signal', 'host-ui', 'guest-shutdown', 'guest-reset',
> -            'guest-panic', 'subsystem-reset'] }
> +            'guest-panic', 'subsystem-reset', 'snapshot-load'] }
>  
>  ##
>  # @StatusInfo:

[...]