From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A169C38A2D for ; Tue, 25 Oct 2022 07:03:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1onDpI-0000Im-G0; Tue, 25 Oct 2022 02:54:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onDAT-0004pY-Lj for qemu-devel@nongnu.org; Tue, 25 Oct 2022 02:12:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onDAS-00074C-2E for qemu-devel@nongnu.org; Tue, 25 Oct 2022 02:12:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666678321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L8hjIvDnvVcum4YCzfjgQLXwqjGPHZoZklUfAjupr0c=; b=IHc3veOMAIsgzHMf7/J4txPz0n6O2/xXQiNs0TqUe07PBmaYetY1JrSOqi7Ptv6oewpCaN d5PQMqIIZtfvPT5v7CNgvA9IaqAdKlc4CSJy7LKWlXM7RuQA9kAT9JEsMMUeE9XgIA/r3i nL+Itez2J5pe3nWk+oblAgLMRko87nk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-205-1ejYpGFiPe2FGZ8262CZxw-1; Tue, 25 Oct 2022 02:11:55 -0400 X-MC-Unique: 1ejYpGFiPe2FGZ8262CZxw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 06B0D882820; Tue, 25 Oct 2022 06:11:55 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.195.118]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B1134202903F; Tue, 25 Oct 2022 06:11:53 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 57B0921E6936; Tue, 25 Oct 2022 08:11:51 +0200 (CEST) From: Markus Armbruster To: "Jason A. Donenfeld" Cc: peter.maydell@linaro.org, pbonzini@redhat.com, qemu-devel@nongnu.org, richard.henderson@linaro.org Subject: Re: [PATCH v4 01/11] reset: allow registering handlers that aren't called by snapshot loading References: <20221025004327.568476-1-Jason@zx2c4.com> <20221025004327.568476-2-Jason@zx2c4.com> Date: Tue, 25 Oct 2022 08:11:51 +0200 In-Reply-To: <20221025004327.568476-2-Jason@zx2c4.com> (Jason A. Donenfeld's message of "Tue, 25 Oct 2022 02:43:17 +0200") Message-ID: <874jvs5t5k.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.503, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org "Jason A. Donenfeld" writes: > Snapshot loading only expects to call deterministic handlers, not > non-deterministic ones. So introduce a way of registering handlers that > won't be called when reseting for snapshots. > > Signed-off-by: Jason A. Donenfeld [...] > diff --git a/qapi/run-state.json b/qapi/run-state.json > index 49989d30e6..e44c0de914 100644 > --- a/qapi/run-state.json > +++ b/qapi/run-state.json > @@ -86,12 +86,15 @@ > # ignores --no-reboot. This is useful for sanitizing > # hypercalls on s390 that are used during kexec/kdump/boot > # > +# @snapshot-load: A snapshot is being loaded by the record & replay > +# subsystem; internal value (since 7.2) > +# If "internal value" was an established way to mark parts that aren't visible externally, this would do. Since it isn't, it's too terse. Suggest something like "This value is used only within QEMU. It doesn't occur in QMP." > ## > { 'enum': 'ShutdownCause', > # Beware, shutdown_caused_by_guest() depends on enumeration order > 'data': [ 'none', 'host-error', 'host-qmp-quit', 'host-qmp-system-reset', > 'host-signal', 'host-ui', 'guest-shutdown', 'guest-reset', > - 'guest-panic', 'subsystem-reset'] } > + 'guest-panic', 'subsystem-reset', 'snapshot-load'] } > > ## > # @StatusInfo: [...]