From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 380AEC04A95 for ; Wed, 28 Sep 2022 08:07:44 +0000 (UTC) Received: from localhost ([::1]:45326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odS6Y-00020L-Tv for qemu-devel@archiver.kernel.org; Wed, 28 Sep 2022 04:07:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odQxT-00044i-3L; Wed, 28 Sep 2022 02:54:16 -0400 Received: from ams.source.kernel.org ([145.40.68.75]:42054) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odQxQ-0004hD-0X; Wed, 28 Sep 2022 02:54:13 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 39FF5B81F0F; Wed, 28 Sep 2022 06:54:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EBCB3C433C1; Wed, 28 Sep 2022 06:54:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664348045; bh=NIE8VRMBt435+iQrD4JTTQgkTE6qkoY3u9UInHa0qlo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OgjmWVkzLg5kepV3JyH3KD7MiSr6pmB2//yknPDDEZFFz7WEFg7JWXScNBaMGeWCF KVZsBe/xWdGJ4tR+1iBlJoHrRAfhff9CTebtShhfnmkKI+FIcDZWdQwgRi0dnM+RDN Y6MwYf+NCmjzBWGB13GtQElFdgmkdFwpDyGgYWR0SaDUJz8jDfUG3CqKq68aZL5KHc t5H8R+dZS9ACORiBIp9PKx8rfqEOjvj6l9p8qzqUX41rkDsXCNh2OSjnzXLTA63v1T jWQv4MQn2mgbtt2KQJWd88SmpuOywdNTLUrGqiS98yJis7jhITjrWG5pWa3og5lpcR mi5wEg93s759w== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1odQxG-00DBVq-Kw; Wed, 28 Sep 2022 07:54:02 +0100 Date: Wed, 28 Sep 2022 07:52:58 +0100 Message-ID: <874jwshtx1.wl-maz@kernel.org> From: Marc Zyngier To: Zenghui Yu , Richard Henderson Cc: , Subject: Re: [PATCH] target/arm: Use the max page size in a 2-stage ptw In-Reply-To: <06d21135-7114-a848-1a49-d0aec16597a8@huawei.com> References: <20220913135643.55728-1-richard.henderson@linaro.org> <06d21135-7114-a848-1a49-d0aec16597a8@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Received-SPF: pass client-ip=145.40.68.75; envelope-from=maz@kernel.org; helo=ams.source.kernel.org X-Spam_score_int: -71 X-Spam_score: -7.2 X-Spam_bar: ------- X-Spam_report: (-7.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 28 Sep 2022 05:34:53 +0100, Zenghui Yu wrote: > > [ Fix Marc's email address ] Ah, many thanks Zenghui! I was wondering whether my discussion with Richard had any result. As it turns out, it had an almost immediate result! > > On 2022/9/13 21:56, Richard Henderson wrote: > > We had only been reporting the stage2 page size. This causes > > problems if stage1 is using a larger page size (16k, 2M, etc), > > but stage2 is using a smaller page size, because cputlb does > > not set large_page_{addr,mask} properly. > > > > Fix by using the max of the two page sizes. > > > > Reported-by: Marc Zyngier This is no longer a thing (and hasn't been for over 3 years! ;-). maz@kernel.org is the canonical address. > > Signed-off-by: Richard Henderson > > --- > > > > Hi Mark, I think this will fix the issue that you mentioned on Monday. > > It certainly appears to fit the bill vs the described symptoms. > > > > This is based on my ptw.c rewrite, full tree at > > > > https://gitlab.com/rth7680/qemu/-/tree/tgt-arm-rme > > > > Based-on: 20220822152741.1617527-1-richard.henderson@linaro.org > > ("[PATCH v2 00/66] target/arm: Implement FEAT_HAFDBS") Thanks Richard. I'll try and give it a spin shortly. Cheers, M. -- Without deviation from the norm, progress is not possible.