* [PATCH] gitlab: split deprecated job into build/check stages
@ 2020-10-02 9:15 Alex Bennée
2020-10-02 10:06 ` Thomas Huth
0 siblings, 1 reply; 3+ messages in thread
From: Alex Bennée @ 2020-10-02 9:15 UTC (permalink / raw)
To: qemu-devel
Cc: Philippe Mathieu-Daudé, Thomas Huth, Alex Bennée,
Wainer dos Santos Moschetta
While the job is pretty fast for only a few targets we still want to
catch breakage of the build. By splitting the test step we can
allow_failures for that while still ensuring we don't miss the build
breaking.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
.gitlab-ci.yml | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 346f23acf7..a51c89554f 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -270,9 +270,24 @@ build-deprecated:
variables:
IMAGE: debian-all-test-cross
CONFIGURE_ARGS: --disable-docs --disable-tools
- MAKE_CHECK_ARGS: check-tcg
+ MAKE_CHECK_ARGS: build-tcg
TARGETS: ppc64abi32-linux-user tilegx-linux-user lm32-softmmu
unicore32-softmmu
+ artifacts:
+ expire_in: 2 days
+ paths:
+ - build
+
+# We split the check-tcg step as test failures are expected but we still
+# want to catch the build breaking.
+check-deprecated:
+ <<: *native_test_job_definition
+ needs:
+ - job: build-deprecated
+ artifacts: true
+ variables:
+ IMAGE: debian-all-test-cross
+ MAKE_CHECK_ARGS: check-tcg
allow_failure: true
build-oss-fuzz:
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gitlab: split deprecated job into build/check stages
2020-10-02 9:15 [PATCH] gitlab: split deprecated job into build/check stages Alex Bennée
@ 2020-10-02 10:06 ` Thomas Huth
2020-10-02 11:26 ` Alex Bennée
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2020-10-02 10:06 UTC (permalink / raw)
To: Alex Bennée, qemu-devel
Cc: Philippe Mathieu-Daudé, Wainer dos Santos Moschetta
On 02/10/2020 11.15, Alex Bennée wrote:
> While the job is pretty fast for only a few targets we still want to
> catch breakage of the build. By splitting the test step we can
> allow_failures for that while still ensuring we don't miss the build
> breaking.
Is there already something broken?
Otherwise, I'd rather simply remove the "allow_failure: true" tag
instead ... these jobs otherwise tend to get ignored.
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> .gitlab-ci.yml | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 346f23acf7..a51c89554f 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -270,9 +270,24 @@ build-deprecated:
> variables:
> IMAGE: debian-all-test-cross
> CONFIGURE_ARGS: --disable-docs --disable-tools
> - MAKE_CHECK_ARGS: check-tcg
> + MAKE_CHECK_ARGS: build-tcg
> TARGETS: ppc64abi32-linux-user tilegx-linux-user lm32-softmmu
> unicore32-softmmu
> + artifacts:
> + expire_in: 2 days
> + paths:
> + - build
> +
> +# We split the check-tcg step as test failures are expected but we still
> +# want to catch the build breaking.
> +check-deprecated:
> + <<: *native_test_job_definition
> + needs:
> + - job: build-deprecated
> + artifacts: true
> + variables:
> + IMAGE: debian-all-test-cross
> + MAKE_CHECK_ARGS: check-tcg
Anyway, that's better than before, so:
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gitlab: split deprecated job into build/check stages
2020-10-02 10:06 ` Thomas Huth
@ 2020-10-02 11:26 ` Alex Bennée
0 siblings, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2020-10-02 11:26 UTC (permalink / raw)
To: Thomas Huth
Cc: Philippe Mathieu-Daudé, qemu-devel,
Wainer dos Santos Moschetta
Thomas Huth <thuth@redhat.com> writes:
> On 02/10/2020 11.15, Alex Bennée wrote:
>> While the job is pretty fast for only a few targets we still want to
>> catch breakage of the build. By splitting the test step we can
>> allow_failures for that while still ensuring we don't miss the build
>> breaking.
>
> Is there already something broken?
>
> Otherwise, I'd rather simply remove the "allow_failure: true" tag
> instead ... these jobs otherwise tend to get ignored.
Yeah I got a recurring ppc64abi32-linux-user failure as I was testing
the PR.
>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>> .gitlab-ci.yml | 17 ++++++++++++++++-
>> 1 file changed, 16 insertions(+), 1 deletion(-)
>>
>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>> index 346f23acf7..a51c89554f 100644
>> --- a/.gitlab-ci.yml
>> +++ b/.gitlab-ci.yml
>> @@ -270,9 +270,24 @@ build-deprecated:
>> variables:
>> IMAGE: debian-all-test-cross
>> CONFIGURE_ARGS: --disable-docs --disable-tools
>> - MAKE_CHECK_ARGS: check-tcg
>> + MAKE_CHECK_ARGS: build-tcg
>> TARGETS: ppc64abi32-linux-user tilegx-linux-user lm32-softmmu
>> unicore32-softmmu
>> + artifacts:
>> + expire_in: 2 days
>> + paths:
>> + - build
>> +
>> +# We split the check-tcg step as test failures are expected but we still
>> +# want to catch the build breaking.
>> +check-deprecated:
>> + <<: *native_test_job_definition
>> + needs:
>> + - job: build-deprecated
>> + artifacts: true
>> + variables:
>> + IMAGE: debian-all-test-cross
>> + MAKE_CHECK_ARGS: check-tcg
>
> Anyway, that's better than before, so:
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
--
Alex Bennée
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-02 11:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-02 9:15 [PATCH] gitlab: split deprecated job into build/check stages Alex Bennée
2020-10-02 10:06 ` Thomas Huth
2020-10-02 11:26 ` Alex Bennée
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).