From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:32798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1glu5k-0003Dd-67 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 06:19:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1glu5j-0003HU-A3 for qemu-devel@nongnu.org; Tue, 22 Jan 2019 06:19:40 -0500 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:51680) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1glu5j-0003A4-2g for qemu-devel@nongnu.org; Tue, 22 Jan 2019 06:19:39 -0500 Received: by mail-wm1-x342.google.com with SMTP id b11so13743112wmj.1 for ; Tue, 22 Jan 2019 03:19:32 -0800 (PST) References: <20190117185628.21862-1-crosa@redhat.com> <20190117185628.21862-3-crosa@redhat.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <20190117185628.21862-3-crosa@redhat.com> Date: Tue, 22 Jan 2019 11:19:30 +0000 Message-ID: <874la10wjh.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 02/18] Acceptance tests: show avocado test execution by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cleber Rosa Cc: qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Stefan Markovic , Aleksandar Markovic , Eduardo Habkost , Caio Carrara , qemu-s390x@nongnu.org, Aurelien Jarno , Cornelia Huck , Fam Zheng , Wainer dos Santos Moschetta , Aleksandar Rikalo Cleber Rosa writes: > The current version of the "check-acceptance" target will only show > one line for execution of all tests. That's probably OK if the tests > to be run are quick enough and they're always the same. > > But, there's already one test alone that takes on average ~5 seconds > to run, we intend to adapt the list of tests to match the user's build > environment (among other choices). > > Because of that, let's present the default Avocado UI by default. > Users can always choose a different output by setting the AVOCADO_SHOW > variable. > > Signed-off-by: Cleber Rosa Reviewed-by: Alex Benn=C3=A9e > --- > .travis.yml | 2 +- > tests/Makefile.include | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 93fd0164a0..844d514afa 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -188,7 +188,7 @@ matrix: > # Acceptance (Functional) tests > - env: > - CONFIG=3D"--python=3D/usr/bin/python3 --target-list=3Dx86_64-s= oftmmu" > - - TEST_CMD=3D"make AVOCADO_SHOW=3Dapp check-acceptance" > + - TEST_CMD=3D"make check-acceptance" > addons: > apt: > packages: > diff --git a/tests/Makefile.include b/tests/Makefile.include > index f403a6571d..c73298740d 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -956,7 +956,7 @@ TESTS_RESULTS_DIR=3D$(BUILD_DIR)/tests/results > # Controls the output generated by Avocado when running tests. > # Any number of command separated loggers are accepted. For more > # information please refer to "avocado --help". > -AVOCADO_SHOW=3Dnone > +AVOCADO_SHOW=3Dapp > > PYTHON3 =3D $(shell $(PYTHON) -c 'import sys; print(1 if sys.version_inf= o >=3D (3, 0) else 0)') > ifeq ($(PYTHON3), 1) -- Alex Benn=C3=A9e