From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dq22O-0005Vc-0q for qemu-devel@nongnu.org; Thu, 07 Sep 2017 15:00:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dq22I-0005Rr-Vu for qemu-devel@nongnu.org; Thu, 07 Sep 2017 15:00:28 -0400 Received: from mail-wr0-x22a.google.com ([2a00:1450:400c:c0c::22a]:34248) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dq22I-0005RD-JF for qemu-devel@nongnu.org; Thu, 07 Sep 2017 15:00:22 -0400 Received: by mail-wr0-x22a.google.com with SMTP id v109so1065548wrc.1 for ; Thu, 07 Sep 2017 12:00:22 -0700 (PDT) References: <20170817230114.3655-1-richard.henderson@linaro.org> <20170817230114.3655-5-richard.henderson@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <20170817230114.3655-5-richard.henderson@linaro.org> Date: Thu, 07 Sep 2017 20:00:18 +0100 Message-ID: <874lsemj0d.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 4/8] tcg: Add operations for host vectors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org Richard Henderson writes: > Nothing uses or implements them yet. > > Signed-off-by: Richard Henderson > --- > tcg/tcg-opc.h | 89 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > tcg/tcg.h | 24 ++++++++++++++++ > 2 files changed, 113 insertions(+) > > diff --git a/tcg/tcg-opc.h b/tcg/tcg-opc.h > index 956fb1e9f3..9162125fac 100644 > --- a/tcg/tcg-opc.h > +++ b/tcg/tcg-opc.h > @@ -206,6 +206,95 @@ DEF(qemu_st_i64, 0, TLADDR_ARGS + DATA64_ARGS, 1, > > #undef TLADDR_ARGS > #undef DATA64_ARGS > + > +/* Host integer vector operations. */ > +/* These opcodes are required whenever the base vector size is enabled. */ > + > +DEF(mov_v64, 1, 1, 0, IMPL(TCG_TARGET_HAS_v64)) > +DEF(mov_v128, 1, 1, 0, IMPL(TCG_TARGET_HAS_v128)) > +DEF(mov_v256, 1, 1, 0, IMPL(TCG_TARGET_HAS_v256)) > + > +DEF(movi_v64, 1, 0, 1, IMPL(TCG_TARGET_HAS_v64)) > +DEF(movi_v128, 1, 0, 1, IMPL(TCG_TARGET_HAS_v128)) > +DEF(movi_v256, 1, 0, 1, IMPL(TCG_TARGET_HAS_v256)) > + > +DEF(ld_v64, 1, 1, 1, IMPL(TCG_TARGET_HAS_v64)) > +DEF(ld_v128, 1, 1, 1, IMPL(TCG_TARGET_HAS_v128)) > +DEF(ld_v256, 1, 1, 1, IMPL(TCG_TARGET_HAS_v256)) > + > +DEF(st_v64, 0, 2, 1, IMPL(TCG_TARGET_HAS_v64)) > +DEF(st_v128, 0, 2, 1, IMPL(TCG_TARGET_HAS_v128)) > +DEF(st_v256, 0, 2, 1, IMPL(TCG_TARGET_HAS_v256)) > + > +DEF(and_v64, 1, 2, 0, IMPL(TCG_TARGET_HAS_v64)) > +DEF(and_v128, 1, 2, 0, IMPL(TCG_TARGET_HAS_v128)) > +DEF(and_v256, 1, 2, 0, IMPL(TCG_TARGET_HAS_v256)) > + > +DEF(or_v64, 1, 2, 0, IMPL(TCG_TARGET_HAS_v64)) > +DEF(or_v128, 1, 2, 0, IMPL(TCG_TARGET_HAS_v128)) > +DEF(or_v256, 1, 2, 0, IMPL(TCG_TARGET_HAS_v256)) > + > +DEF(xor_v64, 1, 2, 0, IMPL(TCG_TARGET_HAS_v64)) > +DEF(xor_v128, 1, 2, 0, IMPL(TCG_TARGET_HAS_v128)) > +DEF(xor_v256, 1, 2, 0, IMPL(TCG_TARGET_HAS_v256)) > + > +DEF(add8_v64, 1, 2, 0, IMPL(TCG_TARGET_HAS_v64)) > +DEF(add16_v64, 1, 2, 0, IMPL(TCG_TARGET_HAS_v64)) > +DEF(add32_v64, 1, 2, 0, IMPL(TCG_TARGET_HAS_v64)) > + > +DEF(add8_v128, 1, 2, 0, IMPL(TCG_TARGET_HAS_v128)) > +DEF(add16_v128, 1, 2, 0, IMPL(TCG_TARGET_HAS_v128)) > +DEF(add32_v128, 1, 2, 0, IMPL(TCG_TARGET_HAS_v128)) > +DEF(add64_v128, 1, 2, 0, IMPL(TCG_TARGET_HAS_v128)) > + > +DEF(add8_v256, 1, 2, 0, IMPL(TCG_TARGET_HAS_v256)) > +DEF(add16_v256, 1, 2, 0, IMPL(TCG_TARGET_HAS_v256)) > +DEF(add32_v256, 1, 2, 0, IMPL(TCG_TARGET_HAS_v256)) > +DEF(add64_v256, 1, 2, 0, IMPL(TCG_TARGET_HAS_v256)) > + > +DEF(sub8_v64, 1, 2, 0, IMPL(TCG_TARGET_HAS_v64)) > +DEF(sub16_v64, 1, 2, 0, IMPL(TCG_TARGET_HAS_v64)) > +DEF(sub32_v64, 1, 2, 0, IMPL(TCG_TARGET_HAS_v64)) > + > +DEF(sub8_v128, 1, 2, 0, IMPL(TCG_TARGET_HAS_v128)) > +DEF(sub16_v128, 1, 2, 0, IMPL(TCG_TARGET_HAS_v128)) > +DEF(sub32_v128, 1, 2, 0, IMPL(TCG_TARGET_HAS_v128)) > +DEF(sub64_v128, 1, 2, 0, IMPL(TCG_TARGET_HAS_v128)) > + > +DEF(sub8_v256, 1, 2, 0, IMPL(TCG_TARGET_HAS_v256)) > +DEF(sub16_v256, 1, 2, 0, IMPL(TCG_TARGET_HAS_v256)) > +DEF(sub32_v256, 1, 2, 0, IMPL(TCG_TARGET_HAS_v256)) > +DEF(sub64_v256, 1, 2, 0, IMPL(TCG_TARGET_HAS_v256)) > + > +/* These opcodes are optional. > + All element counts must be supported if any are. */ > + > +DEF(not_v64, 1, 1, 0, IMPL(TCG_TARGET_HAS_not_v64)) > +DEF(not_v128, 1, 1, 0, IMPL(TCG_TARGET_HAS_not_v128)) > +DEF(not_v256, 1, 1, 0, IMPL(TCG_TARGET_HAS_not_v256)) > + > +DEF(andc_v64, 1, 2, 0, IMPL(TCG_TARGET_HAS_andc_v64)) > +DEF(andc_v128, 1, 2, 0, IMPL(TCG_TARGET_HAS_andc_v128)) > +DEF(andc_v256, 1, 2, 0, IMPL(TCG_TARGET_HAS_andc_v256)) > + > +DEF(orc_v64, 1, 2, 0, IMPL(TCG_TARGET_HAS_orc_v64)) > +DEF(orc_v128, 1, 2, 0, IMPL(TCG_TARGET_HAS_orc_v128)) > +DEF(orc_v256, 1, 2, 0, IMPL(TCG_TARGET_HAS_orc_v256)) > + > +DEF(neg8_v64, 1, 1, 0, IMPL(TCG_TARGET_HAS_neg_v64)) > +DEF(neg16_v64, 1, 1, 0, IMPL(TCG_TARGET_HAS_neg_v64)) > +DEF(neg32_v64, 1, 1, 0, IMPL(TCG_TARGET_HAS_neg_v64)) > + > +DEF(neg8_v128, 1, 1, 0, IMPL(TCG_TARGET_HAS_neg_v128)) > +DEF(neg16_v128, 1, 1, 0, IMPL(TCG_TARGET_HAS_neg_v128)) > +DEF(neg32_v128, 1, 1, 0, IMPL(TCG_TARGET_HAS_neg_v128)) > +DEF(neg64_v128, 1, 1, 0, IMPL(TCG_TARGET_HAS_neg_v128)) > + > +DEF(neg8_v256, 1, 1, 0, IMPL(TCG_TARGET_HAS_neg_v256)) > +DEF(neg16_v256, 1, 1, 0, IMPL(TCG_TARGET_HAS_neg_v256)) > +DEF(neg32_v256, 1, 1, 0, IMPL(TCG_TARGET_HAS_neg_v256)) > +DEF(neg64_v256, 1, 1, 0, IMPL(TCG_TARGET_HAS_neg_v256)) > + > #undef IMPL > #undef IMPL64 > #undef DEF > diff --git a/tcg/tcg.h b/tcg/tcg.h > index 1277caed3d..b9e15da13b 100644 > --- a/tcg/tcg.h > +++ b/tcg/tcg.h > @@ -166,6 +166,30 @@ typedef uint64_t TCGRegSet; > #define TCG_TARGET_HAS_rem_i64 0 > #endif > > +#ifndef TCG_TARGET_HAS_v64 > +#define TCG_TARGET_HAS_v64 0 > +#define TCG_TARGET_HAS_andc_v64 0 > +#define TCG_TARGET_HAS_orc_v64 0 > +#define TCG_TARGET_HAS_not_v64 0 > +#define TCG_TARGET_HAS_neg_v64 0 > +#endif > + > +#ifndef TCG_TARGET_HAS_v128 > +#define TCG_TARGET_HAS_v128 0 > +#define TCG_TARGET_HAS_andc_v128 0 > +#define TCG_TARGET_HAS_orc_v128 0 > +#define TCG_TARGET_HAS_not_v128 0 > +#define TCG_TARGET_HAS_neg_v128 0 > +#endif > + > +#ifndef TCG_TARGET_HAS_v256 > +#define TCG_TARGET_HAS_v256 0 > +#define TCG_TARGET_HAS_andc_v256 0 > +#define TCG_TARGET_HAS_orc_v256 0 > +#define TCG_TARGET_HAS_not_v256 0 > +#define TCG_TARGET_HAS_neg_v256 0 > +#endif Is it possible to use the DEF expanders to avoid manually defining all the TCG_TARGET_HAS_op for each vector size? > + > /* For 32-bit targets, some sort of unsigned widening multiply is required. */ > #if TCG_TARGET_REG_BITS == 32 \ > && !(defined(TCG_TARGET_HAS_mulu2_i32) \ -- Alex Bennée