From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51612) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cTTkx-0000r1-CO for qemu-devel@nongnu.org; Tue, 17 Jan 2017 08:25:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cTTku-0006CS-77 for qemu-devel@nongnu.org; Tue, 17 Jan 2017 08:24:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36826) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cTTkt-0006C1-Uw for qemu-devel@nongnu.org; Tue, 17 Jan 2017 08:24:56 -0500 From: Markus Armbruster References: <1484559200-2301-1-git-send-email-armbru@redhat.com> <87pojmjdep.fsf@dusky.pond.sub.org> <87h94x99e4.fsf@dusky.pond.sub.org> Date: Tue, 17 Jan 2017 14:24:53 +0100 In-Reply-To: (Peter Maydell's message of "Tue, 17 Jan 2017 12:24:25 +0000") Message-ID: <874m0x7ra2.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PULL v2 000/180] QAPI patches for 2017-01-16 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , QEMU Developers Peter Maydell writes: > On 17 January 2017 at 12:08, Markus Armbruster wrote: >> Right now, that'll make no difference whatsoever, because the programs >> that choke on -D generate no output for the commands using the variable >> defined with -D. All they do is gripe. >> >> Three possible solutions, in increasing order of complexity: >> >> 1. Live with the warning from old versions. If a new version comes >> around that does something with @subtitle, it'll just work. >> >> 2. Suppress the warning with @iftex-hammer. No change in output now. >> If a new version comes around that does something with @subtitle, we >> won't profit unless we take out the @iftex. >> >> 3. Replace -D by @set, either by preprocessing .texi, or by including a >> generated snippet. No change in output now. If a new version comes >> around that does something with @subtitle, it'll just work. >> >> My order of preference is aligned with decreasing complexity, i.e. first >> 1., then 2., then 3. >> >> Please tell me what you want. >> >> If you want 3., I can certainly live with it, but I'd rather do 1. or >> 2. now, to get my rather conflict-prone pull request in, then do 3. as a >> follow-up patch. > > Yeah, I think it's reasonable to apply this now and then > fix up the warnings afterwards, since they don't break the > build. I'll do that. Thanks! > In terms of what I'd like for the VERSION issue: > > (1) if it doesn't actually cause a change in the output, we > should either just delete the use of VERSION entirely, or move > it to somewhere outside of @subtitle which does actually > appear somewhere. There's no point in putting in the version > info if it doesn't get into the final output, whether > it generates a warning or not. It does affect PDF output. PDF is generated by texi2pdf, which uses different command line options, and setting VERSION works fine there. > (2) If we want to display VERSION then we need to use @set, > it looks like. We need to decide whether we want to display the information that is now in @subtitle in makeinfo output in addition to PDF output. If yes, we need to put it somewhere else than the subtitle, and find a bug-compatible way to set VERSION. If no, we still might want to silence the warning produced by old versions of makeinfo.