From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhGFO-0003vp-0k for qemu-devel@nongnu.org; Tue, 06 Sep 2016 09:17:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhGFK-0003GS-LC for qemu-devel@nongnu.org; Tue, 06 Sep 2016 09:17:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhGFK-0003Fc-FR for qemu-devel@nongnu.org; Tue, 06 Sep 2016 09:17:02 -0400 From: Juan Quintela In-Reply-To: <20160905111620.GA22359@work-vm> (David Alan Gilbert's message of "Mon, 5 Sep 2016 12:16:21 +0100") References: <1473061514-3619-1-git-send-email-ashijeetacharya@gmail.com> <461a1f33-c9c0-afe3-a0bd-6e059942dab0@redhat.com> <20160905111620.GA22359@work-vm> Reply-To: quintela@redhat.com Date: Tue, 06 Sep 2016 15:16:58 +0200 Message-ID: <874m5tf9rp.fsf@emacs.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] Move migrate_set_speed and migrate_set_downtime into migrate_set_parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: Ashijeet Acharya , Paolo Bonzini , armbru@redhat.com, QEMU Developers , amit.shah@redhat.com, lcapitulino@redhat.com "Dr. David Alan Gilbert" wrote: > * Ashijeet Acharya (ashijeetacharya@gmail.com) wrote: >> On Mon, Sep 5, 2016 at 1:46 PM, Paolo Bonzini wrote: >> > >> > >> > On 05/09/2016 10:11, Ashijeet Acharya wrote: >> >> > > Include migrate_set_speed and migrate_set_downtime inside >> >> > > migrate_set_parameters respectively for setting maximum migration >> >> > > speed and expected downtime parameters. Also add the query part for >> >> > > both in qmp and hmp qemu control interfaces. >> >> > > >> >> > > Signed-off-by: Ashijeet Acharya >> >> > >> >> > You cannot break backwards compatibility for everyone that is using >> >> > those commands, sorry. >> >> >> >> So should I keep the old commands too and add the new ones anyway for >> >> the query part? >> > >> > You do not need query for the old ones, but you can indeed add support >> > for speed and downtime in migrate-set-parameters and MigrationParameters. >> >> Right. So I will add the old-commands back and just add support for the new ones >> under migration-set-parameters along with the query. > > Yes add them to both migrate_set_parameters and query_migrate_parameters > and the hmp equivalents; but don't remove the old functions; just make > them simple wrappers to call the migrate_set_parameters etc. > Add a comment on them like 'kept for compatibility'. I agree with that approach. Thanks, Juan. > > Dave > >> > (Note: I'm not a migration maintainer, so they might say something else). >> >> Okay. I will wait for their views too. >> >> Ashijeet >> > >> > Paolo >> > >> >> The old ones will also be modified for query. So we will have >> >> compatibility as well as the >> >> query. > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK