From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48756)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aTGeR-0000ob-W5
	for qemu-devel@nongnu.org; Tue, 09 Feb 2016 17:20:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aTGeN-0002g1-Hs
	for qemu-devel@nongnu.org; Tue, 09 Feb 2016 17:20:51 -0500
Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:38735)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1aTGeN-0002e9-8q
	for qemu-devel@nongnu.org; Tue, 09 Feb 2016 17:20:47 -0500
Received: by mail-wm0-x22c.google.com with SMTP id p63so3140287wmp.1
	for <qemu-devel@nongnu.org>; Tue, 09 Feb 2016 14:20:45 -0800 (PST)
References: <1455036545-14870-1-git-send-email-den@openvz.org>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1455036545-14870-1-git-send-email-den@openvz.org>
Date: Tue, 09 Feb 2016 22:20:42 +0000
Message-ID: <874mdhwmo5.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>


Denis V. Lunev <den@openvz.org> writes:

> we should call trace_init_backends() before trace_init_file() for
> CONFIG_TRACE_SIMPLE There is no difference for other cases.
>
> This problem was introduced by the commit
>     commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f
>     Author: Paolo Bonzini <pbonzini@redhat.com>
>     Date:   Thu Jan 7 16:55:24 2016 +0300
>
>     trace: split trace_init_file out of trace_init_backends
>
> 'make check' was failed as a result if configured with
>   --enable-trace-backends=simple
>
> Spotted by Alex Bennée.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Alex Bennée <alex.bennee@linaro.org>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>

https://travis-ci.org/stsquad/qemu/builds/108114393

> ---
>  vl.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index c581e39..ffaf8b7 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4098,6 +4098,9 @@ int main(int argc, char **argv, char **envp)
>          exit(0);
>      }
>
> +    if (!trace_init_backends()) {
> +        exit(1);
> +    }
>      trace_init_file(trace_file);
>
>      /* Open the logfile at this point and set the log mask if necessary.
> @@ -4118,10 +4121,6 @@ int main(int argc, char **argv, char **envp)
>          qemu_set_log(0);
>      }
>
> -    if (!trace_init_backends()) {
> -        exit(1);
> -    }
> -
>      /* If no data_dir is specified then try to find it relative to the
>         executable path.  */
>      if (data_dir_idx < ARRAY_SIZE(data_dir)) {


--
Alex Bennée