From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X72V4-0008Vj-Ud for qemu-devel@nongnu.org; Tue, 15 Jul 2014 09:10:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X72Uy-0006q6-TY for qemu-devel@nongnu.org; Tue, 15 Jul 2014 09:10:30 -0400 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:59646 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X72Uy-0006pb-O1 for qemu-devel@nongnu.org; Tue, 15 Jul 2014 09:10:24 -0400 References: <1405424541-21803-1-git-send-email-alex.bennee@linaro.org> <1405424541-21803-4-git-send-email-alex.bennee@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= Date: Tue, 15 Jul 2014 14:10:47 +0100 In-reply-to: Message-ID: <874myiydfm.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 3/3] trace: instrument and trace tcg tb flush activity List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: mohamad.gebai@gmail.com, QEMU Developers , Stefan Hajnoczi , Andreas =?utf-8?Q?F=C3=A4rber?= Peter Maydell writes: > On 15 July 2014 12:42, Alex Bennée wrote: >> +#ifndef CONFIG_TRACE_NOP >> +static inline void trace_inc_counter(int *counter) { >> + int cnt = *counter; >> + cnt++; >> + *counter = cnt; >> +} > > ...why isn't this just "*counter++;" ? You of course mean: (*counter)++; I'll fix that up for the next iteration... -- Alex Bennée