From: Juan Quintela <quintela@redhat.com>
To: Peter Lieven <pl@kamp.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Question about RAM migration flags
Date: Sat, 10 May 2014 10:33:21 +0200 [thread overview]
Message-ID: <874n0y119q.fsf@elfo.mitica> (raw)
In-Reply-To: <778D6AEF-A15C-4299-A629-A6C9AD321807@kamp.de> (Peter Lieven's message of "Fri, 9 May 2014 14:40:02 +0200")
Peter Lieven <pl@kamp.de> wrote:
>> Am 09.05.2014 um 11:43 schrieb "Dr. David Alan Gilbert" <dgilbert@redhat.com>:
>>
>> * Peter Lieven (pl@kamp.de) wrote:
>>> Hi,
>>>
>>> while working on ram migration and reading through the code I realized that
>>> qemu does not stop loading a saved VM or rejecting an incoming migration
>>> if there is a flag in the stream that it does not understand. An unknown flag
>>> is simply ignored.
>>>
>>> In the block migration code there is a catch at the end complaining about
>>> unknown flags, but in RAM migration there isn't.
>>>
>>> Is this on purpose or an error?
>>
>> I think it's in error; the code doesn't have much checking.
>
> i will prepare a patch.
Thanks.
prev parent reply other threads:[~2014-05-10 8:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 23:08 [Qemu-devel] Question about RAM migration flags Peter Lieven
2014-05-09 2:39 ` ChenLiang
2014-05-09 9:43 ` Dr. David Alan Gilbert
2014-05-09 12:40 ` Peter Lieven
2014-05-10 8:33 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874n0y119q.fsf@elfo.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).