From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53954)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Wj2iu-0006Q2-Ry
	for qemu-devel@nongnu.org; Sat, 10 May 2014 04:33:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Wj2ip-0000Ed-Ux
	for qemu-devel@nongnu.org; Sat, 10 May 2014 04:33:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58200)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Wj2ip-0000Dw-OY
	for qemu-devel@nongnu.org; Sat, 10 May 2014 04:33:31 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <778D6AEF-A15C-4299-A629-A6C9AD321807@kamp.de> (Peter Lieven's
	message of "Fri, 9 May 2014 14:40:02 +0200")
References: <536C0E5A.2030703@kamp.de> <20140509094322.GB2423@work-vm>
	<778D6AEF-A15C-4299-A629-A6C9AD321807@kamp.de>
Date: Sat, 10 May 2014 10:33:21 +0200
Message-ID: <874n0y119q.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] Question about RAM migration flags
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Peter Lieven <pl@kamp.de> wrote:
>> Am 09.05.2014 um 11:43 schrieb "Dr. David Alan Gilbert" <dgilbert@redhat.com>:
>> 
>> * Peter Lieven (pl@kamp.de) wrote:
>>> Hi,
>>> 
>>> while working on ram migration and reading through the code I realized that
>>> qemu does not stop loading a saved VM or rejecting an incoming migration
>>> if there is a flag in the stream that it does not understand. An unknown flag
>>> is simply ignored.
>>> 
>>> In the block migration code there is a catch at the end complaining about
>>> unknown flags, but in RAM migration there isn't.
>>> 
>>> Is this on purpose or an error?
>> 
>> I think it's in error; the code doesn't have much checking.
>
> i will prepare a patch.

Thanks.