From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34293)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WNULo-0003vO-31
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 17:36:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WNULi-0004Kx-42
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 17:36:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45195)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1WNULh-0004Ks-SB
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 17:36:34 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1392713429-18201-4-git-send-email-mrhines@linux.vnet.ibm.com>
	(mrhines@linux.vnet.ibm.com's message of "Tue, 18 Feb 2014 16:50:20
	+0800")
References: <1392713429-18201-1-git-send-email-mrhines@linux.vnet.ibm.com>
	<1392713429-18201-4-git-send-email-mrhines@linux.vnet.ibm.com>
Date: Tue, 11 Mar 2014 22:36:15 +0100
Message-ID: <874n341kq8.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [RFC PATCH v2 03/12] mc: introduce a
	'checkpointing' status check into the VCPU states
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: mrhines@linux.vnet.ibm.com
Cc: GILR@il.ibm.com, SADEKJ@il.ibm.com, pbonzini@redhat.com, qemu-devel@nongnu.org, EREZH@il.ibm.com, owasserm@redhat.com, junqing.wang@cs2c.com.cn, onom@us.ibm.com, hinesmr@cn.ibm.com, isaku.yamahata@gmail.com, gokul@us.ibm.com, dbulkow@gmail.com, abali@us.ibm.com, BIRAN@il.ibm.com, lig.fnst@cn.fujitsu.com, "Michael R. Hines" <mrhines@us.ibm.com>

mrhines@linux.vnet.ibm.com wrote:
> From: "Michael R. Hines" <mrhines@us.ibm.com>
>
> During micro-checkpointing, the VCPUs get repeatedly paused and
> resumed. We need to not freak out when the VM begins micro-checkpointing.
>
> Signed-off-by: Michael R. Hines <mrhines@us.ibm.com>
> diff --git a/include/migration/migration.h b/include/migration/migration.h
> index 3e1e6c7..9c62e2f 100644
> --- a/include/migration/migration.h
> +++ b/include/migration/migration.h
> @@ -121,10 +121,31 @@ uint64_t skipped_mig_bytes_transferred(void);
>  uint64_t skipped_mig_pages_transferred(void);
>  uint64_t norm_mig_bytes_transferred(void);
>  uint64_t norm_mig_pages_transferred(void);
> +uint64_t norm_mig_log_dirty_time(void);
> +uint64_t norm_mig_bitmap_time(void);
>  uint64_t xbzrle_mig_bytes_transferred(void);
>  uint64_t xbzrle_mig_pages_transferred(void);
>  uint64_t xbzrle_mig_pages_overflow(void);
>  uint64_t xbzrle_mig_pages_cache_miss(void);
> +void acct_clear(void);
> +
> +void migrate_set_state(MigrationState *s, int old_state, int new_state);
> +
> +enum {
> +    MIG_STATE_ERROR = -1,
> +    MIG_STATE_NONE,
> +    MIG_STATE_SETUP,
> +    MIG_STATE_CANCELLED,
> +    MIG_STATE_CANCELLING,
> +    MIG_STATE_ACTIVE,
> +    MIG_STATE_CHECKPOINTING,
> +    MIG_STATE_COMPLETED,
> +};
> +
> +int mc_enable_buffering(void);
> +int mc_start_buffer(void);
> +void mc_init_checkpointer(MigrationState *s);
> +void mc_process_incoming_checkpoints_if_requested(QEMUFile *f);
>  
>  void ram_handle_compressed(void *host, uint8_t ch, uint64_t size);
>  

This clearly don't work on this patch.

Rest of it is ok.

Later, Juan.