From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ur5lp-0001Et-Ar for qemu-devel@nongnu.org; Mon, 24 Jun 2013 08:21:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ur5ln-0007aI-Rg for qemu-devel@nongnu.org; Mon, 24 Jun 2013 08:21:21 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:45600) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ur5ln-0007aC-MQ for qemu-devel@nongnu.org; Mon, 24 Jun 2013 08:21:19 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 24 Jun 2013 08:21:19 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 9BF6638C8051 for ; Mon, 24 Jun 2013 08:21:14 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5OCLFFD288036 for ; Mon, 24 Jun 2013 08:21:15 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5OCLEtN018497 for ; Mon, 24 Jun 2013 09:21:15 -0300 From: Anthony Liguori In-Reply-To: <20130624080242.GA3338@dhcp-200-207.str.redhat.com> References: <1372018066-21822-1-git-send-email-mail@kevin-wolf.de> <87zjugwlp2.fsf@codemonkey.ws> <20130624080242.GA3338@dhcp-200-207.str.redhat.com> Date: Mon, 24 Jun 2013 07:21:10 -0500 Message-ID: <874ncnd7ih.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 0/3] multiboot: Fix memory information List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pbonzini@redhat.com, Kevin Wolf , qemu-devel@nongnu.org Kevin Wolf writes: > Am 23.06.2013 um 23:39 hat Anthony Liguori geschrieben: >> Kevin Wolf writes: >> >> > Kevin Wolf (3): >> > multiboot: Don't forget last mmap entry >> > multiboot: Calculate upper_mem in the ROM >> > multiboot: Updated ROM binary >> >> Reviewed-by: Anthony Liguori >> >> Do you have a test case that triggered this that you can share? > > I haven't seen an actual kernel failure myself, this was reported by > someone else. But it's easy enough to check with a simple Multiboot > kernel that just outputs lower_mem/upper_mem and the mmap. > > For debugging and fixing I added some throw-away debug code to an > existing kernel and compared the fixed version with the output when > loaded by GRUB and it matches now. > > If we can have a real test case for this somewhere, I can write a small > kernel to do the check. Not sure where it would fit though - probably > kvm-unittests is the closest, even though the test wouldn't really have > anything to do with KVM. We could put it in pc-bios even with just a README for now. Would be nice to figure out ways to test -kernel as we do find issues often enough. It's up to you. If you had something handy, I was going to add it to my local test setup. Regards, Anthony Liguori > >> I'll apply this after a day or so when others have had a chance to review. > > Sounds good, thanks. > > Kevin