From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uf8r5-0006cF-I4 for qemu-devel@nongnu.org; Wed, 22 May 2013 09:13:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uf8r0-0006IC-GL for qemu-devel@nongnu.org; Wed, 22 May 2013 09:13:23 -0400 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:47828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uf8qz-0005vS-Tm for qemu-devel@nongnu.org; Wed, 22 May 2013 09:13:18 -0400 Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 22 May 2013 23:04:25 +1000 From: Anthony Liguori In-Reply-To: <1369066884-431-1-git-send-email-peter.maydell@linaro.org> References: <1369066884-431-1-git-send-email-peter.maydell@linaro.org> Date: Wed, 22 May 2013 08:12:21 -0500 Message-ID: <874ndvp39m.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] qapi-schema.json: Reformat TargetType enum to one-per-line List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, John Rigby , Andreas =?utf-8?Q?F=C3=A4rber?= , patches@linaro.org Peter Maydell writes: > Reformat the qapi-schema TargetType enumeration so that it has just > one target architecture name per line. This allows patches for > adding new targets to just add a single line, rather than having > to reformat most of the list (resulting in a hard-to-check diff). > > Signed-off-by: Peter Maydell > --- > d15a9c23 is an example of what you get otherwise. > > I would much prefer it if we autogenerated this list so you didn't > need to change this file at all to add a new target, but Anthony > is against that; so this is at least an improvement. I don't object to autogenerating it. I object to autogenerating based on the selected targets. The enum should be fixed regardless of what the configure line is. Regards, Anthony Liguori > > qapi-schema.json | 30 ++++++++++++++++++++++++++---- > 1 file changed, 26 insertions(+), 4 deletions(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index 199744a..a8d361e 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3018,10 +3018,32 @@ > # Since: 1.2.0 > ## > { 'enum': 'TargetType', > - 'data': [ 'alpha', 'arm', 'cris', 'i386', 'lm32', 'm68k', 'microblazeel', > - 'microblaze', 'mips64el', 'mips64', 'mipsel', 'mips', 'moxie', > - 'or32', 'ppc64', 'ppcemb', 'ppc', 's390x', 'sh4eb', 'sh4', > - 'sparc64', 'sparc', 'unicore32', 'x86_64', 'xtensaeb', 'xtensa' ] } > + 'data': [ 'alpha', > + 'arm', > + 'cris', > + 'i386', > + 'lm32', > + 'm68k', > + 'microblazeel', > + 'microblaze', > + 'mips64el', > + 'mips64', > + 'mipsel', > + 'mips', > + 'moxie', > + 'or32', > + 'ppc64', > + 'ppcemb', > + 'ppc', > + 's390x', > + 'sh4eb', > + 'sh4', > + 'sparc64', > + 'sparc', > + 'unicore32', > + 'x86_64', > + 'xtensaeb', > + 'xtensa' ] } > > ## > # @TargetInfo: > -- > 1.7.9.5