[Qemu-devel] [Qemu-trivial] [PATCH] configure: silencing pkg-config's check for curses

[Qemu-devel] [Qemu-trivial] [PATCH] configure: silencing pkg-config's check for curses

[Vadim Evard]

>From d10856f3b1d893b5d3c6ab213eb921d0a24e7766 Mon Sep 17 00:00:00 2001
From: Vadim Evard <v.e.evard@gmail.com>
Date: Wed, 16 Jan 2013 03:45:44 +0400
Subject: [PATCH] configure: silencing pkg-config's check for curses

---
 configure |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 4ebb60d..6211db9 100755
--- a/configure
+++ b/configure
@@ -2039,7 +2039,7 @@ fi
 if test "$mingw32" = "yes" ; then
     curses_list="-lpdcurses"
 else
-    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)"
+    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses 2>/dev/null)"
 fi
 
 if test "$curses" != "no" ; then
-- 
1.7.10.4

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: silencing pkg-config's check for curses

[Stefan Hajnoczi]

On Wed, Jan 16, 2013 at 03:52:58AM +0400, Vadim Evard wrote:
> From d10856f3b1d893b5d3c6ab213eb921d0a24e7766 Mon Sep 17 00:00:00 2001
> From: Vadim Evard <v.e.evard@gmail.com>
> Date: Wed, 16 Jan 2013 03:45:44 +0400
> Subject: [PATCH] configure: silencing pkg-config's check for curses
> 
> ---
>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Probably best if Anthony or another qemu.git committer applies this
straight away instead of waiting for the next qemu-trivial pull request.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: silencing pkg-config's check for curses

[Anthony Liguori]

Vadim Evard <v.e.evard@gmail.com> writes:

>>From d10856f3b1d893b5d3c6ab213eb921d0a24e7766 Mon Sep 17 00:00:00 2001
> From: Vadim Evard <v.e.evard@gmail.com>
> Date: Wed, 16 Jan 2013 03:45:44 +0400
> Subject: [PATCH] configure: silencing pkg-config's check for curses


This is fubar above and it's missing a Signed-off-by.  Please CC me when
you send out a new version that fixes this.

Regards,

Anthony Liguori

>
> ---
>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 4ebb60d..6211db9 100755
> --- a/configure
> +++ b/configure
> @@ -2039,7 +2039,7 @@ fi
>  if test "$mingw32" = "yes" ; then
>      curses_list="-lpdcurses"
>  else
> -    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)"
> +    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses 2>/dev/null)"
>  fi
>  
>  if test "$curses" != "no" ; then
> -- 
> 1.7.10.4

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence pkg-config's check for curses

[Vadim Evard]

Signed-off-by: Vadim Evard <v.e.evard@gmail.com>
---
 configure |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 4ebb60d..6211db9 100755
--- a/configure
+++ b/configure
@@ -2039,7 +2039,7 @@ fi
 if test "$mingw32" = "yes" ; then
     curses_list="-lpdcurses"
 else
-    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)"
+    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses 2>/dev/null)"
 fi
 
 if test "$curses" != "no" ; then
-- 
1.7.10.4

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence pkg-config's check for curses

[Anthony Liguori]

Vadim Evard <v.e.evard@gmail.com> writes:

> Signed-off-by: Vadim Evard <v.e.evard@gmail.com>

Please post this as a top-level patch. (no in-reply-to)

Regards,

Anthony Liguori

> ---
>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 4ebb60d..6211db9 100755
> --- a/configure
> +++ b/configure
> @@ -2039,7 +2039,7 @@ fi
>  if test "$mingw32" = "yes" ; then
>      curses_list="-lpdcurses"
>  else
> -    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)"
> +    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses 2>/dev/null)"
>  fi
>  
>  if test "$curses" != "no" ; then
> -- 
> 1.7.10.4

[Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence pkg-config's check for curses

[Vadim Evard]

Signed-off-by: Vadim Evard <v.e.evard@gmail.com>
---
 configure |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 4ebb60d..6211db9 100755
--- a/configure
+++ b/configure
@@ -2039,7 +2039,7 @@ fi
 if test "$mingw32" = "yes" ; then
     curses_list="-lpdcurses"
 else
-    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)"
+    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses 2>/dev/null)"
 fi
 
 if test "$curses" != "no" ; then
-- 1.7.10.4
 	

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence pkg-config's check for curses

[Stefan Hajnoczi]

On Fri, Jan 18, 2013 at 05:48:04PM +0400, Vadim Evard wrote:
> Signed-off-by: Vadim Evard <v.e.evard@gmail.com>
> ---
>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence pkg-config's check for curses

[Vadim Evard]

Thank you!

By the way (sorry if this was discussed before and is a strong decision) 
I'd say e-mail based workflow is of course very flexible - and very very 
novice-unfriendly. Dash, I had to learn git commands I'd never use in my 
usual workflow with local or Github repos. And, well, I was not very 
good with that. 10 ways with 10 options in each. You all saw my previous 
patch mail with "fubar" header and no signed-off-by string.

Is there a reason you (team) don't use e.g. Github at least for trivial 
patches?

Regards,
Vadim

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] configure: silence pkg-config's check for curses

[Stefan Hajnoczi]

On Mon, Jan 21, 2013 at 01:36:54AM +0400, Vadim Evard wrote:
> By the way (sorry if this was discussed before and is a strong
> decision) I'd say e-mail based workflow is of course very flexible -
> and very very novice-unfriendly. Dash, I had to learn git commands
> I'd never use in my usual workflow with local or Github repos. And,
> well, I was not very good with that. 10 ways with 10 options in
> each. You all saw my previous patch mail with "fubar" header and no
> signed-off-by string.
> 
> Is there a reason you (team) don't use e.g. Github at least for
> trivial patches?

Yes, the email-based approach is the most flexible but also has a
learning curve.  For one-time contributors it can seem like wasted
effort.

The QEMU community is familiar with the email-based workflow and has
customized it.  One key idea is that all patches go through
qemu-devel@nongnu.org - even trivial patches are exposed to code review
from the whole community.  A new vector for code submission still needs
to keep this property.

For another open source project that I'm involved in I have set up a
cronjob that sends GitHub pull requests to the project mailing list.
This way the mailing list still sees all patches before they get
committed.  Replying to patches doesn't work though - you still need to
log into GitHub in order to send comments to the author.  I can't ask
all QEMU developers to do that.

Any ideas how to make GitHub work with QEMU?

Stefan