From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TswwJ-0002Y2-Qx for qemu-devel@nongnu.org; Wed, 09 Jan 2013 09:47:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TswwI-00053q-Kr for qemu-devel@nongnu.org; Wed, 09 Jan 2013 09:47:35 -0500 Received: from mail-ie0-f180.google.com ([209.85.223.180]:44205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TswwI-00053k-GB for qemu-devel@nongnu.org; Wed, 09 Jan 2013 09:47:34 -0500 Received: by mail-ie0-f180.google.com with SMTP id c10so2192910ieb.11 for ; Wed, 09 Jan 2013 06:47:33 -0800 (PST) From: Anthony Liguori In-Reply-To: <50ED473A.7040209@redhat.com> References: <1357631962-10484-1-git-send-email-kraxel@redhat.com> <87mwwj22wo.fsf@codemonkey.ws> <50EC38FF.7010801@redhat.com> <87obgzzm3q.fsf@codemonkey.ws> <20130109100935.GB20716@redhat.com> <50ED473A.7040209@redhat.com> Date: Wed, 09 Jan 2013 08:47:30 -0600 Message-ID: <874niqbegt.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH] pc: rename machine types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , "Daniel P. Berrange" Cc: qemu-devel@nongnu.org Gerd Hoffmann writes: > On 01/09/13 11:09, Daniel P. Berrange wrote: > >>>> I don't care that much what the actual names are. Using piix + q35 is >>>> inconsistent, so it isn't that a good choice indeed. So what now? >>>> >>>> (1) We could go for the host bridge and use 'i440fx' + 'q35'. >>>> (2) We could go for the south bridge and use 'piix' + 'ich9'. >> >> Either of these sound fine to me, with a slight preference for the >> first option. >> >>>> (3) Something different? >> >> If we really want 'pc' in the name, then >> >> (4) pci440fx & pcq35 >> (5) pcpiix & pcich9 > > A dash would improve readability, also we have isapc which has pc as > postfix, so maybe 'i440fx-pc' + 'q35-pc' ? > >>> The issue I have with 'i440fx' and 'q35' is that it's basically >>> gibberish to a non-QEMU developer. >> >> With my users and/or libvirt developers hat on, I don't agree really. >> What Gerd suggests clearly states the hardware type being used by the >> machine. I think 'pc' is pretty much meaningless as a machine name >> because it can mean pretty much anything you want to it. It is akin >> to just calling your network device 'nic' and your disk device 'disk', >> which QEMU doesn't do for obvious reasons. > > Fully agree. It also follows the convention of other archs (just look > at the arm machine names). Okay, I'm fine with i440fx-pc/q35-pc (with a slight preference for pc-{i440fx,q35}). Regards, Anthony Liguori > > cheers, > Gerd