From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52197)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TTB7Y-0000Ul-Nw
	for qemu-devel@nongnu.org; Tue, 30 Oct 2012 08:40:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TTB7S-0002mB-Uu
	for qemu-devel@nongnu.org; Tue, 30 Oct 2012 08:40:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:61590)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1TTB7S-0002ly-N4
	for qemu-devel@nongnu.org; Tue, 30 Oct 2012 08:40:34 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9UCeYZj031405
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 30 Oct 2012 08:40:34 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <1350555758-29988-10-git-send-email-pbonzini@redhat.com> (Paolo
	Bonzini's message of "Thu, 18 Oct 2012 12:22:35 +0200")
References: <1350555758-29988-1-git-send-email-pbonzini@redhat.com>
	<1350555758-29988-10-git-send-email-pbonzini@redhat.com>
Date: Tue, 30 Oct 2012 13:40:30 +0100
Message-ID: <874nlcjfpd.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 09/12] migration: close socket QEMUFile
	from socket_close
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

Paolo Bonzini <pbonzini@redhat.com> wrote:
> The common suffix now is process_incoming_migration+qemu_fclose.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com> 

> diff --git a/migration-unix.c b/migration-unix.c
> index def1969..46e04fc 100644
> --- a/migration-unix.c
> +++ b/migration-unix.c
> @@ -144,6 +144,8 @@ static void unix_accept_incoming_migration(void *opaque)
>  
>      process_incoming_migration(f);
>      qemu_fclose(f);
> +    return;
> +
>  out:
>      close(c);

If we are donig this, removing the goto looks like one option?