From: Anthony Liguori <aliguori@us.ibm.com>
To: Luiz Capitulino <lcapitulino@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] win32: fix broken build due to missing QEMU_MADV_HUGEPAGE
Date: Fri, 26 Oct 2012 10:34:05 -0500 [thread overview]
Message-ID: <874nlh458y.fsf@codemonkey.ws> (raw)
In-Reply-To: <20121024141215.737e0f2a@doriath.home>
Luiz Capitulino <lcapitulino@redhat.com> writes:
> Commit ad0b5321f1f797274603ebbe20108b0750baee94 forgot to add
> QEMU_MADV_HUGEPAGE macros for when CONFIG_MADVISE is not defined.
> This broke the build for Windows. Fix it.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> osdep.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/osdep.h b/osdep.h
> index c5fd3d9..585e2c1 100644
> --- a/osdep.h
> +++ b/osdep.h
> @@ -121,6 +121,7 @@ void qemu_vfree(void *ptr);
> #define QEMU_MADV_DONTFORK QEMU_MADV_INVALID
> #define QEMU_MADV_MERGEABLE QEMU_MADV_INVALID
> #define QEMU_MADV_DONTDUMP QEMU_MADV_INVALID
> +#define QEMU_MADV_HUGEPAGE QEMU_MADV_INVALID
>
> #else /* no-op */
>
> @@ -129,6 +130,7 @@ void qemu_vfree(void *ptr);
> #define QEMU_MADV_DONTFORK QEMU_MADV_INVALID
> #define QEMU_MADV_MERGEABLE QEMU_MADV_INVALID
> #define QEMU_MADV_DONTDUMP QEMU_MADV_INVALID
> +#define QEMU_MADV_HUGEPAGE QEMU_MADV_INVALID
>
> #endif
>
> --
> 1.7.12.315.g682ce8b
prev parent reply other threads:[~2012-10-26 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 16:12 [Qemu-devel] [PATCH] win32: fix broken build due to missing QEMU_MADV_HUGEPAGE Luiz Capitulino
2012-10-25 20:24 ` Stefan Weil
2012-10-26 15:34 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874nlh458y.fsf@codemonkey.ws \
--to=aliguori@us.ibm.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).