From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49196) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQdu2-0008FG-9F for qemu-devel@nongnu.org; Tue, 23 Oct 2012 08:48:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQdtx-0006RP-Nf for qemu-devel@nongnu.org; Tue, 23 Oct 2012 08:48:14 -0400 Received: from mail-oa0-f45.google.com ([209.85.219.45]:49129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQdtx-0006RJ-I4 for qemu-devel@nongnu.org; Tue, 23 Oct 2012 08:48:09 -0400 Received: by mail-oa0-f45.google.com with SMTP id i18so3362233oag.4 for ; Tue, 23 Oct 2012 05:48:08 -0700 (PDT) From: Anthony Liguori In-Reply-To: <5086582C.4020804@redhat.com> References: <508549EA.4050603@redhat.com> <50864130.6040103@redhat.com> <5086582C.4020804@redhat.com> Date: Tue, 23 Oct 2012 07:47:48 -0500 Message-ID: <874nllfj7v.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] qemu <-> libvirt interaction broken List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , Peter Maydell Cc: "qemu-devel@nongnu.org" , Aurelien Jarno Gerd Hoffmann writes: > On 10/23/12 10:19, Peter Maydell wrote: >> On 23 October 2012 08:03, Gerd Hoffmann wrote: >>> On 10/22/12 15:51, Peter Maydell wrote: >>>> On 22 October 2012 14:28, Gerd Hoffmann wrote: >>>>> Commit 585f60368f23e6603cf86cfdaeceb89d1169f4b8 appearently breaks the >>>>> libvirt feature detection, my guests fail to start with this message: >>>>> >>>>> error: Failed to start domain fedora-org-virtio >>>>> error: internal error qemu does not support SGA >>>>> >>>>> Running libvirt-0.10.2-2.el6.x86_64 >>>> >>>> Yeah, this is the commit that means you need an updated libvirt >>>> from this point on (and in particular for qemu-1.3). >>> >>> Well, only problem is that 0.10.2 already is the latest libvirt release. >>> Was it really intentional to break things like this? >> >> This change was postponed to after 1.2 was released to >> give libvirt a chance to wean itself off parsing our --help >> output. > > Yea, I know this has been the plan for a long time and I agree that it > is a good move. > > Only problem is that the switch didn't happen yet. The bits might be > landed in libvirt/master, but there is no release with this yet and thus > libvirt versions using QOM for feature detection didn't find the way yet > into distributions. > > IMO it is a bit early to stop caring about -help output compatibility in > qemu. It was announced. There's been plenty of time to adapt. If you're using QEMU from git, it's reasonable to require libvirt from git IMHO. By the time 1.3 goes out, there should be a libvirt release with the necessary support so if your using distro packages, you'll never notice. Regards, Anthony Liguori > > cheers, > Gerd