From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Swddn-0007qR-NB for qemu-devel@nongnu.org; Wed, 01 Aug 2012 14:27:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Swddl-0004mB-Pg for qemu-devel@nongnu.org; Wed, 01 Aug 2012 14:27:27 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:45207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Swddl-0004m2-JZ for qemu-devel@nongnu.org; Wed, 01 Aug 2012 14:27:25 -0400 Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 1 Aug 2012 12:27:21 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id B441C3E4003C for ; Wed, 1 Aug 2012 18:26:53 +0000 (WET) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q71IQMA4165856 for ; Wed, 1 Aug 2012 12:26:24 -0600 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q71IQFDJ032719 for ; Wed, 1 Aug 2012 12:26:18 -0600 From: Anthony Liguori In-Reply-To: <50195034.9050201@suse.de> References: <1343049748-11539-1-git-send-email-imammedo@redhat.com> <87zk6elisw.fsf@codemonkey.ws> <50195034.9050201@suse.de> Date: Wed, 01 Aug 2012 13:25:53 -0500 Message-ID: <874nom8o5q.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/2 v3] target-i386: refactor reset handling and move it into cpu.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: peter.maydell@linaro.org, ehabkost@redhat.com, gleb@redhat.com, jan.kiszka@siemens.com, mtosatti@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, Igor Mammedov Andreas F=C3=A4rber writes: > Am 01.08.2012 17:43, schrieb Anthony Liguori: >> Igor Mammedov writes: >>=20 >>> v2: >>> ommited moving of x86_cpu_realize() from cpu_x86_init() to pc_new_cpu= (), >>> to keep cpu_init implementation in -softmmu and -user targets the same >>> in single place and maintanable. >>> >>> v3: >>> reuse cpu_is_bsp() rather than open code check if apicbase has BSP bi= t set >>> >>> tree for testing: >>> https://github.com/imammedo/qemu/tree/x86_reset_v3 >>> >>> comiple & run tested with x86_64-linux-user, x86_64-softmmu targets >>> >>> Igor Mammedov (2): >>> target-i386: move cpu halted decision into x86_cpu_reset >>> target-i386: move cpu_reset and reset callback to cpu.c >>=20 >> Applied all. Thanks. > > So do you intend to refactor all machines accordingly or leave it > inconsistent now? Are you asking me? No, I have no intention of touching any other machine. We're not going to limit cleaning up target-i386 unless every other machine is cleaned up too. Reset logic should live in the CPU. Seems like a no-brainer to me. Regards, Anthony Liguori > > Andreas > >>=20 >> Regards, >>=20 >> Anthony Liguori >>=20 >>> >>> hw/apic.h | 5 ++++- >>> hw/apic_common.c | 16 +++++++++++++--- >>> hw/pc.c | 18 +----------------- >>> target-i386/cpu.c | 30 ++++++++++++++++++++++++++++++ >>> target-i386/helper.c | 1 - >>> target-i386/kvm.c | 4 +++- >>> 6 files changed, 51 insertions(+), 23 deletions(-) >>=20 > > > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3= =BCrnberg